-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package.json with fesm2015 #1273
Comments
Looks good, but points to discuss:
|
Lets skip closure shall we? Its a huge hugeeee maintenance effort. |
|
Lets look at that but not make this a blocker for 2.0. Have had some bad experiences with closure compiler in past |
I would try it and if it doesn't work as a drop in, I would postpone it to after 2.0 |
So can we agree on having only
|
Actually I was going for es5 and fesm(flat esm) |
Or just use https://www.npmjs.com/package/babel-esm-plugin |
Do you know a build system, that can handle fesm? I do not. And I don't know any advantage of fesm vs. esm
We should'n need babel at all
But that's only for webpack |
Esm uses native es modules but fesm does not. Fesm are flattened modules, like from webpack. This means we don't have to support native modules but we can ship stuff like async await, classes and more of es6 |
We should definitely include the files in es module format, without that there is no tree-shaking and with es modules included in all modern browser and node.js it will definitely the future, also because it's the only standardized module system. |
@prateekbh Reading the docs, they do use es modules, but there is no good build system, but |
We should bundle both esm/es5 files in every package and expose them using fesm format
Spec details:
"Angular Package Format" on Google Docs
The text was updated successfully, but these errors were encountered: