Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signals passed to event-handlers stop updating #607

Open
2 of 5 tasks
JoviDeCroock opened this issue Oct 8, 2024 · 0 comments · May be fixed by #610
Open
2 of 5 tasks

Signals passed to event-handlers stop updating #607

JoviDeCroock opened this issue Oct 8, 2024 · 0 comments · May be fixed by #610

Comments

@JoviDeCroock
Copy link
Member

  • Check if updating to the latest version resolves the issue

Environment

  • I am using @preact/signals-core
  • I am using @preact/signals
  • I am using @preact/signals-react

Describe the bug

When we pass a signal to an event-handler, the event-handler does not update when the signal updates.

To Reproduce

https://codesandbox.io/p/sandbox/quizzical-dubinsky-2t6fph?file=%2Fsrc%2Findex.js%3A3%2C10&workspaceId=2e3797ed-dfbc-47a1-a0f6-cc1df3dc9874

Steps to reproduce the behavior:

After 5 seconds the event-handler will switch to one where you type it will change the value to bonk.

Expected behavior

It should not invoke the old handler (see logs).

To fix this we might need to opt out event handlers from the optimized update path.

@JoviDeCroock JoviDeCroock linked a pull request Oct 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant