Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Hard-coded compiler #15

Open
MakisH opened this issue Mar 18, 2019 · 2 comments
Open

Makefile: Hard-coded compiler #15

MakisH opened this issue Mar 18, 2019 · 2 comments

Comments

@MakisH
Copy link
Member

MakisH commented Mar 18, 2019

See:

$(OBJDIR)/%.o : adapter/%.cpp
g++ -std=c++11 -I$(YAML)/include -c $< -o $@ $(LIBS)
#$(CC) $(CFLAGS) $(INCLUDES) -c $< -o $@ $(LIBS)

@MakisH
Copy link
Member Author

MakisH commented Mar 19, 2019

Maybe this issue needs a bit more explanation.

Here the user specifies the C and Fortran compilers to use:

# OS-specific options
ifeq ($(UNAME_S),Darwin)
CC = /usr/local/bin/gcc
else
CC = mpicc
endif
FFLAGS = -Wall -O3 -fopenmp $(INCLUDES)
FC = mpifort
# FC = mpif90
# FC = gfortran

But later these are overriden unexpectadly with g++. This could be a problem if completely different compilers are used (e.g. the Intel compiler).

Moreover, here we should use $(CXX) instead of $(CC), although this should automatically be used correctly in most of the cases.

@precice-bot
Copy link

This issue has been mentioned on preCICE Discourse. There might be relevant details there:

https://precice.discourse.group/t/running-fsi-flap-perp-example-with-openfoam-and-calculix/178/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants