-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle solver into a single executable #50
Conversation
How different are the two parameter files? Normally I would expect the switch in there as well. |
I also thought about it. There are some diffs, I guess it could be resolved.
17,19c17,21
< # Time integration scheme
< # 0 = forward, 1 = backward
< set theta = 0.5
---
> # Newmark beta
> set beta = 0.25
>
> # Newmark gamma
> set gamma = 0.5
26,27c28,29
< # mu (shear modulus)
< set mu = 1538462
---
> # Poisson's ratio
> set Poisson's ratio = 0.3
29,30c31,32
< # lambda
< set lambda = 2307692
---
> # Shear modulus
> set Shear modulus = 1538462
47a50,60
> end
>
> subsection Nonlinear solver
> # Number of Newton-Raphson iterations allowed
> set Max iterations Newton-Raphson = 10
>
> # Displacement error tolerance
> set Tolerance displacement = 1.0e-6
>
> # Force residual tolerance
> set Tolerance force = 1.0e-9 |
…nto bundle_solver
Let's put the parameter handling in a separate PR, this one is already rather larger and it would allow to simplify the parameter code. Regarding the name: what about fsi_solid ? or just solid? |
What about |
@davidscn told me this might be valuable input here: I just tried running
It would be nice, if one could just provide a prefix instead of adding the executable to the path:
My current (hacky) solution is:
|
Unify parameter interface for solid solver
@BenjaminRodenberg I addressed your comment in precice/tutorials#166. You can now use the |
According to #48
There are certainly some follow up tasks. However, the overall layout should be fine and not change that much.
Point to discuss: how to name the executable and how to switch between the model?
Currently implemented:
or