Improve footer #406
Open
Improve footer #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dle column, removes icons for Github and Discourse links, #46
MakisH
reviewed
May 13, 2024
| <footer> | ||
| <div class="row text-center"> | ||
| <div class="background-dark"> | ||
| <div class="container"> |
There was a problem hiding this comment.
I think we need more margin at the bottom. It currently seems to be quite tight at the bottom:
| <div class="col-md-4 col-xs-4 text-left"> | ||
| <ul class="list-unstyled"> | ||
| <li> | ||
| <a class="no-icon" href="https://precice.discourse.group"><!-- <i class="fab fa-discourse fa-lg"></i> -->Forum on Discourse</a> |
There was a problem hiding this comment.
Any reason to keep the commented-out icons around?
| <a class="no-icon" href="https://github.com/precice"><!-- <i class="fab fa-github fa-lg"></i> -->preCICE on GitHub</a> | ||
| </li> | ||
| <li> | ||
| <a href="#">License</a> |
There was a problem hiding this comment.
On my list, I will open a PR asap.
| <img alt="Creative Commons License" src="images/licensebutton-by-40_88x31.png" /> | ||
| </a> | ||
| <!-- <br /> | ||
| This work is licensed under a <a rel="license" href="https://creativecommons.org/licenses/by/4.0/">Creative Commons Attribution 4.0 International License</a>. --> |
There was a problem hiding this comment.
This could still be the alt of the img above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.