Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[native] Advance Velox and apply TaskState changes" #24162

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

zuyu
Copy link
Contributor

@zuyu zuyu commented Nov 27, 2024

This reverts commit 0ee4687.

Let's advance velox again after facebookincubator/velox#11681 is merged.

== NO RELEASE NOTE ==

@zuyu zuyu requested a review from a team as a code owner November 27, 2024 20:25
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Nov 27, 2024
@prestodb-ci prestodb-ci requested review from a team, infvg and nishithakbhaskaran and removed request for a team November 27, 2024 20:25
Copy link
Contributor

@yingsu00 yingsu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zuyu facebookincubator/velox#11681 has been merged. Do we still need this PR?

btw PR title "Revert "[native] Advance Velox and apply TaskState changes"
-->
"[native] Revert "[native] Advance Velox and apply TaskState changes"

Copy link
Contributor

@yingsu00 yingsu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add meaningful commit and PR message to explain why this needs to be done? Thanks!

@zuyu
Copy link
Contributor Author

zuyu commented Nov 28, 2024

This PR is needed as a transaction to revert the changes of TaskState in Prestissimo. After merging this PR, we would create a new PR to advance Velox again, as if TaskState changes never exist before.

Regarding PR title: like #23959 and #23566, the title are just generated by git revert <commit>. And I don't think adding additional [native] is needed, as the original commit already contains it.

@zuyu zuyu requested a review from yingsu00 November 28, 2024 01:24
@aditi-pandit
Copy link
Contributor

@zuyu : Why not advance Velox again as facebookincubator/velox#11681 is merged now, and also fix Prestissimo code side by side for it ? The revert makes timelines confusing.

@aditi-pandit aditi-pandit merged commit ad9429d into master Nov 28, 2024
60 checks passed
@aditi-pandit aditi-pandit deleted the task-state-revert branch November 28, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants