Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18.0.0-beta.3 - base-style is affecting all elements #16640

Closed
DbkMG opened this issue Oct 25, 2024 · 2 comments
Closed

18.0.0-beta.3 - base-style is affecting all elements #16640

DbkMG opened this issue Oct 25, 2024 · 2 comments
Assignees
Labels
Resolution: Wontfix Issue will not be fixed due to technical limitations Status: Pending Review Issue or pull request is being reviewed by Core Team

Comments

@DbkMG
Copy link

DbkMG commented Oct 25, 2024

Describe the bug

Testing primeng 18.0.0-beta.3 - some of our components are visible broken because the primeng base-style is affecting all html-elements.
image
is forcing all elements to be box-sizing: border-box

Environment

primeng 18.0.0-beta.3

Reproducer

No response

Angular version

18.2.8

PrimeNG version

18.0.0-beta.3

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

i would expect a scoping via css-class and not defining the box-sizing for all elements

@DbkMG DbkMG added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 25, 2024
@cetincakiroglu cetincakiroglu added this to the 18.0.0-rc.1 milestone Oct 26, 2024
@mertsincan mertsincan removed this from PrimeNG v18 Nov 20, 2024
@cetincakiroglu cetincakiroglu self-assigned this Nov 21, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 21, 2024
@cagataycivici cagataycivici removed this from the 18.0.0-rc.2 milestone Nov 22, 2024
@cagataycivici cagataycivici added the Resolution: Wontfix Issue will not be fixed due to technical limitations label Nov 22, 2024
@cagataycivici
Copy link
Member

That CSS is a must have, we've also added box-sizing to before and after as well. All CSS libraries like Tailwind and Bootstrap use border-box sizing as well which is suggested. I'd definitely suggest switching your app to border-box otherwise you'll always have issues when trying to import a 3rd party UI widget whether it is PrimeNG or not.

Copy link

Unfortunately, this issue cannot be fixed due to technical limitations. PrimeNg team has decided not to pursue a fix, as addressing it would introduce other complications. Thanks a lot for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Wontfix Issue will not be fixed due to technical limitations Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Done
Development

No branches or pull requests

4 participants