Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc cleanup and fixes #836

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Misc cleanup and fixes #836

merged 1 commit into from
Aug 14, 2024

Conversation

mperrotti
Copy link
Contributor

As I was working on porting component docs over to the new primer.style site, I noticed a few small mistakes we could fix in our existing docs:

  • ActionList MDX was a little sloppy and contained some outdated info
  • ActionBar was missing a React tab
  • Autocomplete guidelines had a broken link to /action-list
  • InlineMessage was missing a React tab

I opened a related PR to add missing stories in primer/react: primer/react#4847

@mperrotti mperrotti requested a review from a team as a code owner August 13, 2024 20:34
@mperrotti mperrotti mentioned this pull request Aug 13, 2024
Merged
12 tasks
langermank
langermank approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mperrotti mperrotti merged commit 4b58b11 into main Aug 14, 2024
6 checks passed
@mperrotti mperrotti deleted the mp/misc-cleanup-and-fixes branch August 14, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mperrotti @langermank