Remove option large from ButtonGroup story

[lukasoppermann]

According to the docs large is not a valid option.

Changed

Removed large option from storybook property

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

⚠️ No Changeset found

Latest commit: b9c8f4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	104.74 KB (0%)
dist/browser.umd.js	105.32 KB (0%)

[joshblack]

Question for the team, is there anything we can do at a type-level or at runtime to catch this kind of issue? 🤔 cc @primer/react-reviewers

[lukasoppermann]

Question for the team, is there anything we can do at a type-level or at runtime to catch this kind of issue? 🤔 cc https://github.com/orgs/primer/teams/react-reviewers

Couldn't we technically add a size property to buttonGroup instead of just passing the props on?

[joshblack]

@lukasoppermann I think that could definitely be an option 💯 Right now it seems like folks just pass the size option to Button directly. This approach would need some plumbing to set things up (e.g. Button reads from context for it) but is super do-able.

Another pattern might be to iterate through children and provide the size prop through cloneElement but this path feels discouraged these days 😞 (context)