Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more stories for AnchoredOverlay, BranchName, and Checkbox #4847

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Aug 13, 2024

As I was working on the new primer.style site, I noticed that some of our components were missing helpful Storybook stories.

I also opened a PR to clean up some component docs unrelated to these Storybook changes: primer/design#836

Changelog

No changes that would be shipped.

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why
    • Only Storybook stories and E2E tests will be updated, so we don't need a release

Testing & Reviewing

Merge checklist

@mperrotti mperrotti added the skip changeset This change does not need a changelog label Aug 13, 2024
@mperrotti mperrotti requested a review from a team as a code owner August 13, 2024 20:30
Copy link

changeset-bot bot commented Aug 13, 2024

⚠️ No Changeset found

Latest commit: 5bd9d61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 13, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.2 KB (0%)
packages/react/dist/browser.umd.js 96.46 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4847 August 13, 2024 20:35 Inactive
@primer primer bot requested a review from a team as a code owner August 13, 2024 20:39
@primer primer bot requested a review from tbenning August 13, 2024 20:39
@github-actions github-actions bot temporarily deployed to storybook-preview-4847 August 13, 2024 20:43 Inactive
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@emilybrick emilybrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🌞

@mperrotti mperrotti added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 0e83bec Aug 14, 2024
30 checks passed
@mperrotti mperrotti deleted the mp/story-coverage-improvements-082024 branch August 14, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants