Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Text): Remove CSS modules feature flag from Text component #5061

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 4, 2024

This removes the CSS modules feature flag from the Text component that was first introduced 2 months ago #4874

Changelog

Changed

Text is styled by CSS modules.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: 38a2260

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 4, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5061 October 4, 2024 00:02 Inactive
Copy link
Contributor

github-actions bot commented Oct 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.85 KB (-0.1% 🔽)
packages/react/dist/browser.umd.js 103.23 KB (-0.11% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5061 October 7, 2024 23:05 Inactive
@jonrohan jonrohan marked this pull request as ready for review October 8, 2024 18:23
@jonrohan jonrohan requested a review from a team as a code owner October 8, 2024 18:23
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 15, 2024
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 13, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5061 November 13, 2024 19:29 Inactive
@jonrohan jonrohan marked this pull request as draft November 14, 2024 20:10
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/352843

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants