Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing slice IDs #25

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: add missing slice IDs #25

merged 1 commit into from
Sep 6, 2024

Conversation

lihbr
Copy link
Member

@lihbr lihbr commented Sep 5, 2024

Resolves:

Description

Similar to #24, I'll hold off from merging this one until I'm sure I don't need to add other, now mandatory, missing properties 👌

This add:

  • missing slice IDs on slices and shared slices

Checklist

  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

Copy link

github-actions bot commented Sep 5, 2024

size-limit report 📦

Path Size
dist/index.js 11.05 KB (+0.07% 🔺)
dist/index.cjs 14.33 KB (+0.22% 🔺)

@lihbr lihbr marked this pull request as ready for review September 6, 2024 10:01
@lihbr
Copy link
Member Author

lihbr commented Sep 6, 2024

Seems like that's all actually 👌

@lihbr lihbr merged commit 513e92f into main Sep 6, 2024
2 checks passed
@lihbr lihbr deleted the lh/fix-add-missing-slice-id branch September 6, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant