Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an inline SVG icon for the edit button instead of PNG #11

Open
tremby opened this issue Dec 19, 2017 · 2 comments
Open

Use an inline SVG icon for the edit button instead of PNG #11

tremby opened this issue Dec 19, 2017 · 2 comments

Comments

@tremby
Copy link

tremby commented Dec 19, 2017

An SVG would be better.

  • Smaller in payload size
  • Arguably higher quality
  • More stylable
    • Can already be the surrounding text's colour (which might change on hover according to existing <a> style rules)
    • Line and fill colour can be set with CSS
    • Line thickness, corner style, and line end style can be set with CSS

One suggestion would be this MIT-licensed one: https://github.com/danklammer/bytesize-icons/blob/master/dist/icons/edit.svg

@tremby tremby changed the title Use an inline SVG icon instead of PNG Use an inline SVG icon for the edit button instead of PNG Dec 19, 2017
@levimykel
Copy link
Collaborator

@tremby Thanks for this, we will look into it.

@krabbypattified
Copy link
Contributor

This is implemented in the next release glr/preview-predict :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants