-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prismic toolbar can't access previewSession cookie ("lax") on latest chrome release #63
Comments
I dove in the chrome debugger, the issue is that the iframe can't get the document cookies: It's hard to say if it's a bug or a false negative that stayed silent too long, some people debate this here: https://support.google.com/chrome/thread/33543699?hl=en Once I saw this I checked with Edge and the preview works as intended, reads the io.prismic.previewSession cookie. I think there may be some settings to update when setting the cookie to allow it to be extracted from iframe, here some more insight. https://blog.heroku.com/chrome-changes-samesite-cookie It's highly probable that all browsers may embark on this security train and that the preview will gradually stop working on more and more environment until fixed. I would advise to consider this very seriously :) Good luck |
@srenault perfect ! Could you give me some kind of version identifier where the SameSite attribute has been updated, so that I can open an internal request to update it on our side ? Thanks for the support, safe to close. |
The thing is we don't sell custom enterprise instance. Could you give me the repository name of your client so I can check on which version your client is on? |
I emailed you on your public github email. |
I am having 99+ console error because Cookie “io.prismic.previewSession” has been rejected for invalid domain. |
Related issue prismicio/prismic-client#128
I had a setup properly configured and working 3 weeks ago:
The endpoint was correctly set, the prismic toolbar was loaded via https://static.cdn.prismic.io/prismic.min.js
Then, around 3 to 2 weeks ago, the preview feature stopped functioning.
Both of these features were working correctly until recently.
When inspecting the page, I have a valid preview cookie
But the sdk is seemingly not detecting it's on a preview page and is not triggering the splash screen and toolbar as it was 3 weeks ago.
I can't test to roll back to a previous version of my site, even by checkout on a guaranteed functional commit, since the prismic sdk https://static.cdn.prismic.io/prismic.min.js is some kind of a "latest" version only.
I tried to find some documentation on a semver for the cdn, something like https://static.cdn.prismic.io/prismic.min.js?version=2.1 , but did not find any information indicating something like this is in place.
Can you help me investigate this regression ?
The text was updated successfully, but these errors were encountered: