Skip to content
This repository has been archived by the owner on Dec 27, 2023. It is now read-only.

Seamless posting and Facebook link preview #293

Open
irdan opened this issue Aug 27, 2015 · 4 comments
Open

Seamless posting and Facebook link preview #293

irdan opened this issue Aug 27, 2015 · 4 comments

Comments

@irdan
Copy link
Member

irdan commented Aug 27, 2015

I was trying to address this github issue: #289 and ran into a few bugs which I figured would be worth discussing.

  1. During status creation using seamless posting the link preview is confusing because it shows up beneath the message before it is submitted. Especially for new users the link preview that is displayed will be confusing.
  2. After a status is posted the injected privly message iframe is displayed many times and also overlaps with the facebook link preview. This is clearly not what we had in mind. Obviously we could modifying the Facebook DOM directly but that seems like an absolute last resort.
  3. After I initially clicked the lock icon and started typing, the seamless posting area refreshed itself and the first character that I typed shows up in the message that was submitted even though it was not within the green box that was displayed to the user. You don't see the 'T' that is entered, but you can see the cursor move backwards an extra character when I was deleting the start of the message.
  4. After the status is submitted, the seamless posting is still present in the form to enter a new status so another link preview is displayed even though from the users perspective nothing has been entered.
  5. While injection is turned off, the privly-application name and the meta tag description is displayed. Since that is what users without the extension installed will see, we should probably make it more appealing.

This should be multiple issues, but thought this would be a good place to characterize them individually and then create separate issues accordingly.

selection

@smcgregor
Copy link
Member

smcgregor commented Aug 28, 2015 via email

@irdan
Copy link
Member Author

irdan commented Aug 28, 2015

There is a brief flash in the green background after initially clicking on the lock icon. You can replicate the issue if you type as soon as the background appears for the first time. If you're fast enough typing you can see it in the first instance, but the text does not get transferred to the second instance.

@smcgregor
Copy link
Member

Facebook does crazy things with their form elements so it takes a second to resolve the form element that will be receiving the content.

@smcgregor
Copy link
Member

I am going to try to block the Facebook bot at the server level. This may prevent previewing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants