Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] TimePrecision does not work correctly when set min value #83

Open
leminhhieu98py opened this issue Dec 23, 2023 · 6 comments
Open
Labels
bug Something isn't working

Comments

@leminhhieu98py
Copy link

Testing environment: REPL

Reproduce steps

  • Have the code as in the attached image
  • Test with hour by typing alternately 65 -> 54 -> 43 -> 32 -> 21 -> 10 -> 11 -> 12 -> ... -> 19
  • Test around with minutes like testing with hour

As-is: the hour and minute sometimes does not display well when setting min and max
To-be: the hour and minute sometimes should display well when setting min and max

image

@probablykasper
Copy link
Owner

Not sure what exactly the issue is. Could you provide a REPL link and clear specific instructions?

@leminhhieu98py
Copy link
Author

@probablykasper

Please test and confirm whether you can reproduce the phenomenon on your side or not. Thanks ~

@probablykasper
Copy link
Owner

probablykasper commented Dec 24, 2023

Edit: nvm, I see the issue! Confused >= with <=

@leminhhieu98py
Copy link
Author

@probablykasper Hello,

Are you/ your team working on this?

@probablykasper
Copy link
Owner

No, I'm not working on it for now

@probablykasper probablykasper added the bug Something isn't working label Feb 15, 2024
@probablykasper
Copy link
Owner

For now I'd recommend just not using specific min/max values. Instead, you should use a min at the start of a day (0:00:00.000) and a max at the end of a day (23:59:59.999)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants