Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MatchHistory] Cleaning BOM char in dataset column names #751

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sandromodarelli
Copy link

Fixes #750

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.28%. Comparing base (69fb0de) to head (d5eb2d3).
Report is 202 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #751       +/-   ##
===========================================
+ Coverage   59.33%   71.28%   +11.94%     
===========================================
  Files          11       26       +15     
  Lines        1633     2448      +815     
  Branches      336      337        +1     
===========================================
+ Hits          969     1745      +776     
- Misses        610      628       +18     
- Partials       54       75       +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@probberechts
Copy link
Owner

Thanks! Your solution is somewhat of a hack though. Wouldn't it be cleaner to simply use the correct encoding to read the file? The new data seems to use the UTF-8-SIG encoding while older data uses ISO-8859-1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Match History] football-data CSV files about 24/25 season start with BOM char
3 participants