Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop initializing variables in reconcile loop #53

Closed
anishasthana opened this issue Apr 3, 2023 · 1 comment · Fixed by #89
Closed

Stop initializing variables in reconcile loop #53

anishasthana opened this issue Apr 3, 2023 · 1 comment · Fixed by #89
Assignees
@Bobbins228

Comments

@anishasthana
Copy link
Member

We have a large number of variables unnecessarily initialized in the Reconcile loop. We should move these initializations out.
@Bobbins228 Bobbins228 self-assigned this Jun 22, 2023
@Bobbins228 Bobbins228 mentioned this issue Jun 22, 2023
Merged
@Bobbins228 Bobbins228 moved this from In Progress to Ready For Review in Project CodeFlare Sprint Board Jul 10, 2023
@Bobbins228 Bobbins228 moved this from Ready For Review to In Progress in Project CodeFlare Sprint Board Jul 20, 2023
@Bobbins228 Bobbins228 moved this from In Progress to Ready For Review in Project CodeFlare Sprint Board Jul 24, 2023
@Bobbins228
Copy link
Contributor

PR #89

@Bobbins228 Bobbins228 moved this from Ready For Review to In Progress in Project CodeFlare Sprint Board Jul 28, 2023
@Bobbins228 Bobbins228 moved this from In Progress to Ready For Review in Project CodeFlare Sprint Board Sep 11, 2023
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Project CodeFlare Sprint Board Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bobbins228 Bobbins228

Labels
None yet
Projects
Project CodeFlare Sprint Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use controller-runtime to consume Machine API Bobbins228/instascale
2 participants
@anishasthana @Bobbins228