From 8b561c85060f06d5b88c769c9cdb62ce7fe7fc4d Mon Sep 17 00:00:00 2001 From: Nobuhiro Ban Date: Thu, 19 Oct 2023 23:41:37 +0900 Subject: [PATCH] add_entry-symmetry --- include/limestone/api/log_channel.h | 2 +- src/limestone/log_channel.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/limestone/api/log_channel.h b/include/limestone/api/log_channel.h index cadeaff5..ec9d81d4 100644 --- a/include/limestone/api/log_channel.h +++ b/include/limestone/api/log_channel.h @@ -84,7 +84,7 @@ class log_channel { * @param large_objects (optional) the list of large objects associated with the entry to be added * @attention this function is not thread-safe. */ - void add_entry(storage_id_type storage_id, std::string_view key, std::string_view value, write_version_type write_version, const std::vector& large_objects) noexcept; + void add_entry(storage_id_type storage_id, std::string_view key, std::string_view value, write_version_type write_version, const std::vector& large_objects); /** * @brief add an entry indicating the deletion of entries diff --git a/src/limestone/log_channel.cpp b/src/limestone/log_channel.cpp index ccb48ee9..3ce187e5 100644 --- a/src/limestone/log_channel.cpp +++ b/src/limestone/log_channel.cpp @@ -85,9 +85,9 @@ void log_channel::add_entry(storage_id_type storage_id, std::string_view key, st write_version_ = write_version; } -void log_channel::add_entry([[maybe_unused]] storage_id_type storage_id, [[maybe_unused]] std::string_view key, [[maybe_unused]] std::string_view value, [[maybe_unused]] write_version_type write_version, [[maybe_unused]] const std::vector& large_objects) noexcept { +void log_channel::add_entry([[maybe_unused]] storage_id_type storage_id, [[maybe_unused]] std::string_view key, [[maybe_unused]] std::string_view value, [[maybe_unused]] write_version_type write_version, [[maybe_unused]] const std::vector& large_objects) { LOG_LP(ERROR) << "not implemented"; - std::abort(); // FIXME + throw std::runtime_error("not implemented"); // FIXME }; void log_channel::remove_entry(storage_id_type storage_id, std::string_view key, write_version_type write_version) {