Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tgdump --profile PG-Strom. #34

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Enable tgdump --profile PG-Strom. #34

merged 3 commits into from
Dec 22, 2023

Conversation

ashigeru
Copy link
Contributor

@ashigeru ashigeru commented Dec 21, 2023 •
edited
Loading

Important

This PR is work in progress.

This PR introduces --profile PG-Strom option to tgdump command.
It generates table dump as Apache Arrow files optimized for PG-Strom.

Tasks:

  • Enhance dump profile models
  • Make dump profile reader accept the enhanced models
  • Support new protocol buffer fields
  • Add PG-Strom profile

@ashigeru ashigeru self-assigned this Dec 21, 2023
@ashigeru ashigeru marked this pull request as draft December 21, 2023 15:42
@ashigeru
Copy link
Contributor Author

ashigeru commented Dec 22, 2023 •
edited
Loading

@kuron99

Please check the PR: the following instructions may help it.

  1. execute ./gradlew assemble on the project root
  2. pick tgdump package at modules/tgdump/cli/build/distributions/*-shadow-*.tar (the file name is something wrong... it will be changed.)
  3. install the package into Tsurugi env
  4. execute tgdump with --help -> listed built-in dump profiles must contain PG-Strom
  5. execute tgdump with --profile PG-Strom -> generated table dump files must be suitable for PG-Strom
  6. execute tgdump with the environment variable TGDUMP_OPTS="-Dorg.slf4j.simpleLogger.defaultLogLevel=debug" -> shown debug logs contain DEBUG dump options: ... with the contents of DumpOption

kuron99
kuron99 approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@kuron99 kuron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashigeru ashigeru marked this pull request as ready for review December 22, 2023 13:12
@ashigeru ashigeru merged commit b3cdcd0 into master Dec 22, 2023
4 checks passed
@ashigeru ashigeru deleted the wip/tgdump-pgstrom branch December 27, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuron99 kuron99 kuron99 approved these changes

@hishidama hishidama Awaiting requested review from hishidama hishidama is a code owner

Assignees

@ashigeru ashigeru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashigeru @kuron99