Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch LanguageIdentifier type with other Fluent crates #26

Open
hongquan opened this issue Jan 1, 2024 · 1 comment
Open

Mismatch LanguageIdentifier type with other Fluent crates #26

hongquan opened this issue Jan 1, 2024 · 1 comment

Comments

@hongquan
Copy link

hongquan commented Jan 1, 2024

Other Fluent crates use the LanguageIdentifier from unic-langid, whereas fluent-langneg uses one from icu_locid, hence, the result of negotiate_languages cannot be used for other crates.

@zbraniecki
Copy link
Collaborator

Hi, yes, Fluent crates are not yet updated to switch to ICU4X. I'm working on it.

For now, for Fluent needs one should use older version of fluent-langneg, which is what fluent-rs does - https://github.com/projectfluent/fluent-rs/blob/main/Cargo.toml#L19

max-m added a commit to wbbaddons/Tims-PackageServer that referenced this issue Jun 18, 2024
`fluent-langneg` is still blocked by projectfluent/fluent-langneg-rs#26
Upgrading `notify` requires more work and is done on a different branch
TimWolla pushed a commit to wbbaddons/Tims-PackageServer that referenced this issue Jun 19, 2024
`fluent-langneg` is still blocked by projectfluent/fluent-langneg-rs#26
Upgrading `notify` requires more work and is done on a different branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants