Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary Enum usage #245

Open
mgramigna opened this issue May 23, 2023 · 0 comments
Open

Remove unnecessary Enum usage #245

mgramigna opened this issue May 23, 2023 · 0 comments
Labels
breaking Implementation might result in a breaking change infra Tasks related to the underlying infrastructure that won't affect end users
Milestone
v2.0

Comments

@mgramigna
Copy link
Contributor

There are a lot of Enums in fqm-execution that are just strings. We should move to the approach of as const + typeof instead to yield a better TypeScript developer experience.

This change would no longer export the Enums from the library, so it would be a breaking change for developers using fqm-execution
@mgramigna mgramigna added infra Tasks related to the underlying infrastructure that won't affect end users breaking Implementation might result in a breaking change labels May 23, 2023
@mgramigna mgramigna added this to the v2.0 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Implementation might result in a breaking change infra Tasks related to the underlying infrastructure that won't affect end users
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
1 participant
@mgramigna