Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github light high contrast: Floating window has same color as background #324

Open
bluss opened this issue May 9, 2024 · 1 comment
Open
Labels
bug Something isn't working Primer Related-to or caused-by Primer defaults/settings

Comments

@bluss
Copy link

bluss commented May 9, 2024

Using nvim v0.9.5, github-nvim-theme d832925 with lazy.nvim package manager.

It looks like Normal and NormalFloat have the same background color, and this means that things like hover floaters (using NormalFloat) wash out against the background. github light default does not have this problem.

Both light/dark high contrast themes have this same issue.

@tmillr
Copy link
Member

tmillr commented Jul 11, 2024

Thanks for reporting this. You are right, and this only affects github_light_high_contrast and github_dark_high_contrast.

Screenshot 2024-07-11 at 1 19 10 PM

"canvas": {
"default": "#ffffff",
"overlay": "#ffffff",
"inset": "#ffffff",
"subtle": "#e7ecf0"
},

"canvas": {
"default": "#0a0c10",
"overlay": "#272b33",
"inset": "#010409",
"subtle": "#272b33"
},

canvas.default is used for spec.bg1 (global bg), and canvas.inset is used for spec.bg0 (darkened bg)

We might need manual/custom overrides for these two themes (for spec.bg0). In the meantime, you can configure spec.bg0 via setup() locally.

@tmillr tmillr added Primer Related-to or caused-by Primer defaults/settings bug Something isn't working labels Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Primer Related-to or caused-by Primer defaults/settings
Projects
None yet
Development

No branches or pull requests

2 participants