From 830e69814f93bb4629b837081ce1bc9d88848533 Mon Sep 17 00:00:00 2001 From: Oleg Klyuchkin Date: Thu, 8 Feb 2024 20:01:58 +0300 Subject: [PATCH 1/6] feat: Add nginx_exporter role Signed-off-by: anviar --- roles/nginx_exporter/README.md | 44 +++++++ roles/nginx_exporter/defaults/main.yml | 24 ++++ roles/nginx_exporter/handlers/main.yml | 10 ++ roles/nginx_exporter/meta/argument_specs.yml | 71 +++++++++++ roles/nginx_exporter/meta/main.yml | 30 +++++ .../molecule/alternative/molecule.yml | 17 +++ .../molecule/alternative/prepare.yml | 76 ++++++++++++ .../alternative/tests/test_alternative.py | 46 ++++++++ .../molecule/default/molecule.yml | 6 + .../molecule/default/tests/test_default.py | 64 ++++++++++ .../molecule/latest/molecule.yml | 6 + .../molecule/latest/tests/test_latest.py | 43 +++++++ roles/nginx_exporter/tasks/configure.yml | 36 ++++++ roles/nginx_exporter/tasks/install.yml | 69 +++++++++++ roles/nginx_exporter/tasks/main.yml | 63 ++++++++++ roles/nginx_exporter/tasks/preflight.yml | 110 ++++++++++++++++++ roles/nginx_exporter/tasks/selinux.yml | 23 ++++ .../templates/nginx_exporter.service.j2 | 39 +++++++ .../templates/web_config.yaml.j2 | 18 +++ roles/nginx_exporter/test-requirements.txt | 1 + roles/nginx_exporter/vars/main.yml | 11 ++ 21 files changed, 807 insertions(+) create mode 100644 roles/nginx_exporter/README.md create mode 100644 roles/nginx_exporter/defaults/main.yml create mode 100644 roles/nginx_exporter/handlers/main.yml create mode 100644 roles/nginx_exporter/meta/argument_specs.yml create mode 100644 roles/nginx_exporter/meta/main.yml create mode 100644 roles/nginx_exporter/molecule/alternative/molecule.yml create mode 100644 roles/nginx_exporter/molecule/alternative/prepare.yml create mode 100644 roles/nginx_exporter/molecule/alternative/tests/test_alternative.py create mode 100644 roles/nginx_exporter/molecule/default/molecule.yml create mode 100644 roles/nginx_exporter/molecule/default/tests/test_default.py create mode 100644 roles/nginx_exporter/molecule/latest/molecule.yml create mode 100644 roles/nginx_exporter/molecule/latest/tests/test_latest.py create mode 100644 roles/nginx_exporter/tasks/configure.yml create mode 100644 roles/nginx_exporter/tasks/install.yml create mode 100644 roles/nginx_exporter/tasks/main.yml create mode 100644 roles/nginx_exporter/tasks/preflight.yml create mode 100644 roles/nginx_exporter/tasks/selinux.yml create mode 100644 roles/nginx_exporter/templates/nginx_exporter.service.j2 create mode 100644 roles/nginx_exporter/templates/web_config.yaml.j2 create mode 100644 roles/nginx_exporter/test-requirements.txt create mode 100644 roles/nginx_exporter/vars/main.yml diff --git a/roles/nginx_exporter/README.md b/roles/nginx_exporter/README.md new file mode 100644 index 000000000..2b724a3da --- /dev/null +++ b/roles/nginx_exporter/README.md @@ -0,0 +1,44 @@ +

graph logo

+ +# Ansible Role: nginx_exporter + +## Description + +Deploy prometheus [nginx_exporter](https://github.com/nginxinc/nginx-prometheus-exporter) using ansible. + +## Requirements + +- Ansible >= 2.9 (It might work on previous versions, but we cannot guarantee it) +- gnu-tar on Mac deployer host (`brew install gnu-tar`) +- Passlib is required when using the basic authentication feature (`pip install passlib[bcrypt]`) + +## Role Variables + +All variables which can be overridden are stored in [defaults/main.yml](defaults/main.yml) file as well as in [meta/argument_specs.yml](meta/argument_specs.yml). +Please refer to the [collection docs](https://prometheus-community.github.io/ansible/branch/main/nginx_exporter_role.html) for description and default values of the variables. + +## Example + +### Demo site + +We provide demo site for full monitoring solution based on prometheus and grafana. Repository with code and links to running instances is [available on github](https://github.com/prometheus/demo-site) and site is hosted on [DigitalOcean](https://digitalocean.com). + +## Local Testing + +The preferred way of locally testing the role is to use Docker and [molecule](https://github.com/ansible-community/molecule) (v3.x). You will have to install Docker on your system. See "Get started" for a Docker package suitable to for your system. Running your tests is as simple as executing `molecule test`. + +## Continuous Intergation + +Combining molecule and circle CI allows us to test how new PRs will behave when used with multiple ansible versions and multiple operating systems. This also allows use to create test scenarios for different role configurations. As a result we have a quite large test matrix which can take more time than local testing, so please be patient. + +## Contributing + +See [contributor guideline](CONTRIBUTING.md). + +## Troubleshooting + +See [troubleshooting](TROUBLESHOOTING.md). + +## License + +This project is licensed under MIT License. See [LICENSE](/LICENSE) for more details. diff --git a/roles/nginx_exporter/defaults/main.yml b/roles/nginx_exporter/defaults/main.yml new file mode 100644 index 000000000..65d308931 --- /dev/null +++ b/roles/nginx_exporter/defaults/main.yml @@ -0,0 +1,24 @@ +--- +nginx_exporter_version: 1.1.0 +nginx_exporter_binary_local_dir: "" +nginx_exporter_binary_url: "https://github.com/{{ _nginx_exporter_repo }}/releases/download/v{{ nginx_exporter_version }}/\ + nginx-prometheus-exporter_{{ nginx_exporter_version }}_linux_{{ go_arch }}.tar.gz" +nginx_exporter_checksums_url: "https://github.com/{{ _nginx_exporter_repo }}/releases/download/v{{ nginx_exporter_version }}/\ + nginx-prometheus-exporter_{{ nginx_exporter_version }}_checksums.txt" +nginx_exporter_skip_install: false +nginx_exporter_scrape_uri: "http://127.0.0.1/stub_status" +nginx_exporter_web_listen_address: "0.0.0.0:9113" +nginx_exporter_web_telemetry_path: "/metrics" + +nginx_exporter_tls_server_config: {} + +nginx_exporter_http_server_config: {} + +nginx_exporter_basic_auth_users: {} + +nginx_exporter_log_level: "info" +nginx_exporter_log_format: "logfmt" + +nginx_exporter_binary_install_dir: "/usr/local/bin" +nginx_exporter_system_group: "nogroup" +nginx_exporter_system_user: "nobody" diff --git a/roles/nginx_exporter/handlers/main.yml b/roles/nginx_exporter/handlers/main.yml new file mode 100644 index 000000000..8deb77e0d --- /dev/null +++ b/roles/nginx_exporter/handlers/main.yml @@ -0,0 +1,10 @@ +--- +- name: Restart nginx_exporter + listen: "restart nginx_exporter" + become: true + ansible.builtin.systemd: + daemon_reload: true + name: nginx_exporter + state: restarted + when: + - not ansible_check_mode diff --git a/roles/nginx_exporter/meta/argument_specs.yml b/roles/nginx_exporter/meta/argument_specs.yml new file mode 100644 index 000000000..0970f7f2f --- /dev/null +++ b/roles/nginx_exporter/meta/argument_specs.yml @@ -0,0 +1,71 @@ +--- +# yamllint disable rule:line-length +argument_specs: + main: + short_description: "Prometheus nginx_exporter" + description: + - "Deploy prometheus L(nginx exporter,https://github.com/nginxinc/nginx-prometheus-exporter) using ansible" + author: + - "Prometheus Community" + options: + nginx_exporter_version: + description: "nginx_exporter package version. Also accepts latest as parameter." + default: "0.14.2" + nginx_exporter_skip_install: + description: "nginx_exporter installation tasks gets skipped when set to true." + type: bool + default: false + nginx_exporter_binary_local_dir: + description: + - "Enables the use of local packages instead of those distributed on github." + - "The parameter may be set to a directory where the C(nginx_exporter) binary is stored on the host where ansible is run." + - "This overrides the I(nginx_exporter_version) parameter" + nginx_exporter_binary_url: + description: "URL of the nginx_exporter binaries .tar.gz file" + default: "https://github.com/{{ _nginx_exporter_repo }}/releases/download/v{{ nginx_exporter_version }}/nginx_exporter-{{ nginx_exporter_version }}.linux-{{ go_arch }}.tar.gz" + nginx_exporter_checksums_url: + description: "URL of the nginx_exporter checksums file" + default: "https://github.com/{{ _nginx_exporter_repo }}/releases/download/v{{ nginx_exporter_version }}/nginx-prometheus-exporter_{{ nginx_exporter_version }}_checksums.txt" + nginx_exporter_web_listen_address: + description: "Address on which nginx exporter will listen" + default: "0.0.0.0:9113" + nginx_exporter_web_telemetry_path: + description: "Path under which to expose metrics" + default: "/metrics" + nginx_exporter_tls_server_config: + description: + - "Configuration for TLS authentication." + - "Keys and values are the same as in L(nginx_exporter docs,https://github.com/prometheus/exporter-toolkit/blob/master/docs/web-configuration.md)." + type: "dict" + nginx_exporter_http_server_config: + description: + - "Config for HTTP/2 support." + - "Keys and values are the same as in L(nginx_exporter docs,https://github.com/prometheus/exporter-toolkit/blob/master/docs/web-configuration.md)." + type: "dict" + nginx_exporter_basic_auth_users: + description: "Dictionary of users and password for basic authentication. Passwords are automatically hashed with bcrypt." + type: "dict" + nginx_exporter_log_level: + description: "Only log messages with the given severity or above. One of: [debug, info, warn, error]" + default: "info" + nginx_exporter_log_format: + description: "Output format of log messages. One of: [logfmt, json]" + default: "logfmt" + nginx_exporter_scrape_uri: + description: "A URI or unix domain socket path for scraping NGINX or NGINX Plus metrics. For NGINX, the stub_status page must be available through the URI." + default: "http://127.0.0.1/stub_status" + nginx_exporter_binary_install_dir: + description: + - "I(Advanced)" + - "Directory to install nginx_exporter binary" + default: "/usr/local/bin" + nginx_exporter_system_group: + description: + - "I(Advanced)" + - "System group for nginx_exporter" + default: "nogroup" + nginx_exporter_system_user: + description: + - "I(Advanced)" + - "nginx_exporter user" + default: "nobody" diff --git a/roles/nginx_exporter/meta/main.yml b/roles/nginx_exporter/meta/main.yml new file mode 100644 index 000000000..f1a9ece20 --- /dev/null +++ b/roles/nginx_exporter/meta/main.yml @@ -0,0 +1,30 @@ +--- +galaxy_info: + author: "Prometheus Community" + description: "Prometheus nginx_exporter" + license: "Apache" + min_ansible_version: "2.9" + platforms: + - name: "Ubuntu" + versions: + - "focal" + - "jammy" + - name: "Debian" + versions: + - "bullseye" + - "buster" + - name: "EL" + versions: + - "7" + - "8" + - "9" + - name: "Fedora" + versions: + - "37" + - '38' + galaxy_tags: + - "monitoring" + - "prometheus" + - "exporter" + - "metrics" + - "system" diff --git a/roles/nginx_exporter/molecule/alternative/molecule.yml b/roles/nginx_exporter/molecule/alternative/molecule.yml new file mode 100644 index 000000000..02be17c1b --- /dev/null +++ b/roles/nginx_exporter/molecule/alternative/molecule.yml @@ -0,0 +1,17 @@ +--- +provisioner: + inventory: + group_vars: + all: + nginx_exporter_binary_local_dir: "/tmp/nginx_exporter-linux-amd64" + nginx_exporter_web_listen_address: "127.0.0.1:9113" + + nginx_exporter_tls_server_config: + cert_file: /etc/nginx_exporter/tls.cert + key_file: /etc/nginx_exporter/tls.key + nginx_exporter_http_server_config: + http2: true + nginx_exporter_basic_auth_users: + randomuser: examplepassword + go_arch: amd64 + nginx_exporter_version: 1.1.0 diff --git a/roles/nginx_exporter/molecule/alternative/prepare.yml b/roles/nginx_exporter/molecule/alternative/prepare.yml new file mode 100644 index 000000000..b3c1f5e7d --- /dev/null +++ b/roles/nginx_exporter/molecule/alternative/prepare.yml @@ -0,0 +1,76 @@ +--- +- name: Run local preparation + hosts: localhost + gather_facts: false + tasks: + - name: Download nginx_exporter binary to local folder + become: false + ansible.builtin.get_url: + url: "https://github.com/{{ _nginx_exporter_repo }}/releases/download/v{{ nginx_exporter_version }}/\ + nginx-prometheus-exporter-{{ nginx_exporter_version }}_linux-{{ go_arch }}.tar.gz" + dest: "/tmp/nginx_exporter-{{ nginx_exporter_version }}_linux-{{ go_arch }}.tar.gz" + mode: 0644 + register: _download_binary + until: _download_binary is succeeded + retries: 5 + delay: 2 + check_mode: false + + - name: Unpack nginx_exporter binary + become: false + ansible.builtin.unarchive: + src: "/tmp/nginx_exporter-{{ nginx_exporter_version }}_linux-{{ go_arch }}.tar.gz" + dest: "/tmp" + creates: "/tmp/nginx_exporter-{{ nginx_exporter_version }}_linux-{{ go_arch }}/nginx_exporter" + check_mode: false + + - name: Link to nginx_exporter binaries directory + become: false + ansible.builtin.file: + src: "/tmp/nginx_exporter-{{ nginx_exporter_version }}_linux-amd64" + dest: "/tmp/nginx_exporter-linux-amd64" + state: link + check_mode: false + + - name: Install pyOpenSSL for certificate generation + ansible.builtin.pip: + name: "pyOpenSSL" + + - name: Create private key + community.crypto.openssl_privatekey: + path: "/tmp/tls.key" + + - name: Create CSR + community.crypto.openssl_csr: + path: "/tmp/tls.csr" + privatekey_path: "/tmp/tls.key" + + - name: Create certificate + community.crypto.x509_certificate: + path: "/tmp/tls.cert" + csr_path: "/tmp/tls.csr" + privatekey_path: "/tmp/tls.key" + provider: selfsigned + +- name: Run target preparation + hosts: all + any_errors_fatal: true + tasks: + - name: Create nginx_exporter cert dir + ansible.builtin.file: + path: "{{ nginx_exporter_tls_server_config.cert_file | dirname }}" + state: directory + owner: root + group: root + mode: u+rwX,g+rwX,o=rX + + - name: Copy cert and key + ansible.builtin.copy: + src: "{{ item.src }}" + dest: "{{ item.dest }}" + mode: "{{ item.mode | default('0644') }}" + loop: + - src: "/tmp/tls.cert" + dest: "{{ nginx_exporter_tls_server_config.cert_file }}" + - src: "/tmp/tls.key" + dest: "{{ nginx_exporter_tls_server_config.key_file }}" diff --git a/roles/nginx_exporter/molecule/alternative/tests/test_alternative.py b/roles/nginx_exporter/molecule/alternative/tests/test_alternative.py new file mode 100644 index 000000000..d2cb881ef --- /dev/null +++ b/roles/nginx_exporter/molecule/alternative/tests/test_alternative.py @@ -0,0 +1,46 @@ +from __future__ import (absolute_import, division, print_function) +__metaclass__ = type + +import os +import testinfra.utils.ansible_runner + +testinfra_hosts = testinfra.utils.ansible_runner.AnsibleRunner( + os.environ['MOLECULE_INVENTORY_FILE']).get_hosts('all') + + +def test_directories(host): + dirs = [ + "/etc/nginx_exporter" + ] + for dir in dirs: + d = host.file(dir) + assert d.is_directory + assert d.exists + + +def test_service(host): + s = host.service("nginx_exporter") + try: + assert s.is_running + except AssertionError: + # Capture service logs + journal_output = host.run('journalctl -u nginx_exporter --since "1 hour ago"') + print("\n==== journalctl -u nginx_exporter Output ====\n") + print(journal_output) + print("\n============================================\n") + raise # Re-raise the original assertion error + + +def test_protecthome_property(host): + s = host.service("nginx_exporter") + p = s.systemd_properties + assert p.get("ProtectHome") == "yes" + + +def test_socket(host): + sockets = [ + "tcp://127.0.0.1:8080" + ] + for socket in sockets: + s = host.socket(socket) + assert s.is_listening diff --git a/roles/nginx_exporter/molecule/default/molecule.yml b/roles/nginx_exporter/molecule/default/molecule.yml new file mode 100644 index 000000000..311672fc0 --- /dev/null +++ b/roles/nginx_exporter/molecule/default/molecule.yml @@ -0,0 +1,6 @@ +--- +provisioner: + inventory: + group_vars: + all: + nginx_exporter_web_listen_address: "127.0.0.1:9113" diff --git a/roles/nginx_exporter/molecule/default/tests/test_default.py b/roles/nginx_exporter/molecule/default/tests/test_default.py new file mode 100644 index 000000000..0720e119b --- /dev/null +++ b/roles/nginx_exporter/molecule/default/tests/test_default.py @@ -0,0 +1,64 @@ +from __future__ import (absolute_import, division, print_function) +__metaclass__ = type + +import os +import testinfra.utils.ansible_runner + +testinfra_hosts = testinfra.utils.ansible_runner.AnsibleRunner( + os.environ['MOLECULE_INVENTORY_FILE']).get_hosts('all') + + +def test_directories(host): + dirs = [ + "/etc/nginx_exporter" + ] + for dir in dirs: + d = host.file(dir) + assert d.is_directory + assert d.exists + + +def test_files(host): + files = [ + "/etc/systemd/system/nginx_exporter.service", + "/usr/local/bin/nginx-prometheus-exporter" + ] + for file in files: + f = host.file(file) + assert f.exists + assert f.is_file + + +def test_user(host): + assert host.group("www-data").exists + assert "www-data" in host.user("www-data").groups + assert host.user("www-data").shell == "/usr/sbin/nologin" + assert host.user("www-data").home == "/" + + +def test_service(host): + s = host.service("nginx_exporter") + try: + assert s.is_running + except AssertionError: + # Capture service logs + journal_output = host.run('journalctl -u nginx_exporter --since "1 hour ago"') + print("\n==== journalctl -u nginx_exporter Output ====\n") + print(journal_output) + print("\n============================================\n") + raise # Re-raise the original assertion error + + +def test_protecthome_property(host): + s = host.service("nginx_exporter") + p = s.systemd_properties + assert p.get("ProtectHome") == "yes" + + +def test_socket(host): + sockets = [ + "tcp://127.0.0.1:9113" + ] + for socket in sockets: + s = host.socket(socket) + assert s.is_listening diff --git a/roles/nginx_exporter/molecule/latest/molecule.yml b/roles/nginx_exporter/molecule/latest/molecule.yml new file mode 100644 index 000000000..b52f99ade --- /dev/null +++ b/roles/nginx_exporter/molecule/latest/molecule.yml @@ -0,0 +1,6 @@ +--- +provisioner: + inventory: + group_vars: + all: + nginx_exporter_version: latest diff --git a/roles/nginx_exporter/molecule/latest/tests/test_latest.py b/roles/nginx_exporter/molecule/latest/tests/test_latest.py new file mode 100644 index 000000000..fbac26344 --- /dev/null +++ b/roles/nginx_exporter/molecule/latest/tests/test_latest.py @@ -0,0 +1,43 @@ +from __future__ import (absolute_import, division, print_function) +__metaclass__ = type + +import os +import testinfra.utils.ansible_runner +import pytest + +testinfra_hosts = testinfra.utils.ansible_runner.AnsibleRunner( + os.environ['MOLECULE_INVENTORY_FILE']).get_hosts('all') + + +@pytest.mark.parametrize("files", [ + "/etc/systemd/system/nginx_exporter.service", + "/usr/local/bin/nginx_exporter" +]) +def test_files(host, files): + f = host.file(files) + assert f.exists + assert f.is_file + + +def test_service(host): + s = host.service("nginx_exporter") + try: + assert s.is_running + except AssertionError: + # Capture service logs + journal_output = host.run('journalctl -u nginx_exporter --since "1 hour ago"') + print("\n==== journalctl -u nginx_exporter Output ====\n") + print(journal_output) + print("\n============================================\n") + raise # Re-raise the original assertion error + + +def test_protecthome_property(host): + s = host.service("nginx_exporter") + p = s.systemd_properties + assert p.get("ProtectHome") == "yes" + + +def test_socket(host): + s = host.socket("tcp://0.0.0.0:9113") + assert s.is_listening diff --git a/roles/nginx_exporter/tasks/configure.yml b/roles/nginx_exporter/tasks/configure.yml new file mode 100644 index 000000000..55e810ceb --- /dev/null +++ b/roles/nginx_exporter/tasks/configure.yml @@ -0,0 +1,36 @@ +--- +- name: Copy the nginx_exporter systemd service file + ansible.builtin.template: + src: nginx_exporter.service.j2 + dest: /etc/systemd/system/nginx_exporter.service + owner: root + group: root + mode: 0644 + notify: restart nginx_exporter + +- name: Create nginx_exporter config directory + ansible.builtin.file: + path: "/etc/nginx_exporter" + state: directory + owner: root + group: root + mode: u+rwX,g+rwX,o=rX + +- name: Copy the nginx_exporter web config file + ansible.builtin.template: + src: web_config.yaml.j2 + dest: /etc/nginx_exporter/web_config.yaml + owner: root + group: root + mode: 0644 + notify: restart nginx_exporter + +- name: Allow nginx_exporter port in SELinux on RedHat OS family + community.general.seport: + ports: "{{ nginx_exporter_web_listen_address.split(':')[-1] }}" + proto: tcp + setype: http_port_t + state: present + when: + - ansible_version.full is version_compare('2.4', '>=') + - ansible_selinux.status == "enabled" diff --git a/roles/nginx_exporter/tasks/install.yml b/roles/nginx_exporter/tasks/install.yml new file mode 100644 index 000000000..6230d43e2 --- /dev/null +++ b/roles/nginx_exporter/tasks/install.yml @@ -0,0 +1,69 @@ +--- +- name: Create the nginx_exporter group + ansible.builtin.group: + name: "{{ nginx_exporter_system_group }}" + state: present + system: true + when: nginx_exporter_system_group not in ["root", 'www-data', 'nogroup'] + +- name: Create the nginx_exporter user + ansible.builtin.user: + name: "{{ nginx_exporter_system_user }}" + groups: "{{ nginx_exporter_system_group }}" + append: true + shell: /usr/sbin/nologin + system: true + create_home: false + home: / + when: nginx_exporter_system_user not in ["root", 'www-data', 'nobody'] + +- name: Get binary + when: + - nginx_exporter_binary_local_dir | length == 0 + - not nginx_exporter_skip_install + block: + + - name: Download nginx_exporter binary to local folder + become: false + ansible.builtin.get_url: + url: "{{ nginx_exporter_binary_url }}" + dest: "/tmp/nginx-prometheus-exporter_{{ nginx_exporter_version }}_linux_{{ go_arch }}.tar.gz" + checksum: "sha256:{{ __nginx_exporter_checksum }}" + mode: '0644' + register: _download_binary + until: _download_binary is succeeded + retries: 5 + delay: 2 + delegate_to: localhost + check_mode: false + + - name: Unpack nginx_exporter binary + become: false + ansible.builtin.unarchive: + src: "/tmp/nginx-prometheus-exporter_{{ nginx_exporter_version }}_linux_{{ go_arch }}.tar.gz" + dest: "/tmp" + creates: "/tmp/nginx-prometheus-exporter" + delegate_to: localhost + check_mode: false + + - name: Propagate nginx_exporter binaries + ansible.builtin.copy: + src: "/tmp/nginx-prometheus-exporter" + dest: "{{ nginx_exporter_binary_install_dir }}/nginx-prometheus-exporter" + mode: 0755 + owner: root + group: root + notify: restart nginx_exporter + when: not ansible_check_mode + +- name: Propagate locally distributed nginx_exporter binary + ansible.builtin.copy: + src: "{{ nginx_exporter_binary_local_dir }}/nginx-prometheus-exporter" + dest: "{{ nginx_exporter_binary_install_dir }}/nginx-prometheus-exporter" + mode: 0755 + owner: root + group: root + when: + - nginx_exporter_binary_local_dir | length > 0 + - not nginx_exporter_skip_install + notify: restart nginx_exporter diff --git a/roles/nginx_exporter/tasks/main.yml b/roles/nginx_exporter/tasks/main.yml new file mode 100644 index 000000000..760d1b604 --- /dev/null +++ b/roles/nginx_exporter/tasks/main.yml @@ -0,0 +1,63 @@ +--- +- name: Preflight + ansible.builtin.include_tasks: + file: preflight.yml + apply: + tags: + - nginx_exporter_install + - nginx_exporter_configure + - nginx_exporter_run + tags: + - nginx_exporter_install + - nginx_exporter_configure + - nginx_exporter_run + +- name: Install + ansible.builtin.include_tasks: + file: install.yml + apply: + become: true + tags: + - nginx_exporter_install + when: + ( not __nginx_exporter_is_installed.stat.exists ) or + ( (__nginx_exporter_current_version_output.stderr_lines | length > 0) + and (__nginx_exporter_current_version_output.stderr_lines[0].split(" ")[2] != nginx_exporter_version) ) or + ( (__nginx_exporter_current_version_output.stdout_lines | length > 0) + and (__nginx_exporter_current_version_output.stdout_lines[0].split(" ")[2] != nginx_exporter_version) ) or + ( nginx_exporter_binary_local_dir | length > 0 ) + tags: + - nginx_exporter_install + +- name: SELinux + ansible.builtin.include_tasks: + file: selinux.yml + apply: + become: true + tags: + - nginx_exporter_configure + when: ansible_selinux.status == "enabled" + tags: + - nginx_exporter_configure + +- name: Configure + ansible.builtin.include_tasks: + file: configure.yml + apply: + become: true + tags: + - nginx_exporter_configure + tags: + - nginx_exporter_configure + +- name: Ensure nginx_exporter is enabled on boot + become: true + ansible.builtin.systemd: + daemon_reload: true + name: nginx_exporter + enabled: true + state: started + when: + - not ansible_check_mode + tags: + - nginx_exporter_run diff --git a/roles/nginx_exporter/tasks/preflight.yml b/roles/nginx_exporter/tasks/preflight.yml new file mode 100644 index 000000000..8f63bf74e --- /dev/null +++ b/roles/nginx_exporter/tasks/preflight.yml @@ -0,0 +1,110 @@ +--- +- name: Assert usage of systemd as an init system + ansible.builtin.assert: + that: ansible_service_mgr == 'systemd' + msg: "This role only works with systemd" + +- name: Install package fact dependencies + become: true + ansible.builtin.package: + name: "{{ _pkg_fact_req }}" + state: present + when: (_pkg_fact_req) + vars: + _pkg_fact_req: "{% if (ansible_pkg_mgr == 'apt') %}\ + {{ ('python-apt' if ansible_python_version is version('3', '<') else 'python3-apt') }} + {% else %}\ + {% endif %}" + +- name: Gather package facts + ansible.builtin.package_facts: + when: "not 'packages' in ansible_facts" + +- name: Assert that used version supports listen address type + ansible.builtin.assert: + that: + - >- + nginx_exporter_web_listen_address is string + +- name: Naive assertion of proper listen address + ansible.builtin.assert: + that: + - >- + [nginx_exporter_web_listen_address] | + flatten | + reject('match', '.+:\\d+$') | + list | + length == 0 + +- name: Assert that TLS config is correct + when: nginx_exporter_tls_server_config | length > 0 + block: + - name: Assert that TLS key and cert path are set + ansible.builtin.assert: + that: + - "nginx_exporter_tls_server_config.cert_file is defined" + - "nginx_exporter_tls_server_config.key_file is defined" + + - name: Check existence of TLS cert file + ansible.builtin.stat: + path: "{{ nginx_exporter_tls_server_config.cert_file }}" + register: __nginx_exporter_cert_file + + - name: Check existence of TLS key file + ansible.builtin.stat: + path: "{{ nginx_exporter_tls_server_config.key_file }}" + register: __nginx_exporter_key_file + + - name: Assert that TLS key and cert are present + ansible.builtin.assert: + that: + - "__nginx_exporter_cert_file.stat.exists" + - "__nginx_exporter_key_file.stat.exists" + +- name: Check if nginx_exporter is installed + ansible.builtin.stat: + path: "{{ nginx_exporter_binary_install_dir }}/nginx_exporter" + register: __nginx_exporter_is_installed + check_mode: false + tags: + - nginx_exporter_install + +- name: Gather currently installed nginx_exporter version (if any) + ansible.builtin.command: "{{ nginx_exporter_binary_install_dir }}/nginx_exporter --version" + changed_when: false + register: __nginx_exporter_current_version_output + check_mode: false + when: __nginx_exporter_is_installed.stat.exists + tags: + - nginx_exporter_install + +- name: Discover latest version + ansible.builtin.set_fact: + nginx_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _nginx_exporter_repo }}/releases/latest', headers=_github_api_headers, + split_lines=False) | from_json).get('tag_name') | replace('v', '') }}" + run_once: true + until: nginx_exporter_version is version('0.0.0', '>=') + retries: 10 + when: + - nginx_exporter_version == "latest" + - nginx_exporter_binary_local_dir | length == 0 + - not nginx_exporter_skip_install + +- name: Get nginx_exporter binary checksum + when: + - nginx_exporter_binary_local_dir | length == 0 + - not nginx_exporter_skip_install + block: + - name: Get checksum list from github + ansible.builtin.set_fact: + __nginx_exporter_checksums: "{{ lookup('url', nginx_exporter_checksums_url, headers=_github_api_headers, wantlist=True) | list }}" + run_once: true + until: __nginx_exporter_checksums is search('linux_' + go_arch + '.tar.gz') + retries: 10 + + - name: "Get checksum for {{ go_arch }}" + ansible.builtin.set_fact: + __nginx_exporter_checksum: "{{ item.split(' ')[0] }}" + with_items: "{{ __nginx_exporter_checksums }}" + when: + - "item.endswith('nginx-prometheus-exporter_' + nginx_exporter_version + '_linux_' + go_arch + '.tar.gz')" diff --git a/roles/nginx_exporter/tasks/selinux.yml b/roles/nginx_exporter/tasks/selinux.yml new file mode 100644 index 000000000..754cbd0a2 --- /dev/null +++ b/roles/nginx_exporter/tasks/selinux.yml @@ -0,0 +1,23 @@ +--- +- name: Install selinux python packages [RedHat] + ansible.builtin.package: + name: "{{ ['libselinux-python', 'policycoreutils-python'] + if ansible_python_version is version('3', '<') else + ['python3-libselinux', 'python3-policycoreutils'] }}" + state: present + register: _install_selinux_packages + until: _install_selinux_packages is success + retries: 5 + delay: 2 + when: ansible_os_family | lower == "redhat" + +- name: Install selinux python packages [clearlinux] + ansible.builtin.package: + name: sysadmin-basic + state: present + register: _install_selinux_packages + until: _install_selinux_packages is success + retries: 5 + delay: 2 + when: + - ansible_distribution | lower == "clearlinux" diff --git a/roles/nginx_exporter/templates/nginx_exporter.service.j2 b/roles/nginx_exporter/templates/nginx_exporter.service.j2 new file mode 100644 index 000000000..8e0c5aafa --- /dev/null +++ b/roles/nginx_exporter/templates/nginx_exporter.service.j2 @@ -0,0 +1,39 @@ +{{ ansible_managed | comment }} + +[Unit] +Description=Prometheus nginx_exporter +After=network-online.target + +[Service] +Type=simple +User={{ nginx_exporter_system_user }} +Group={{ nginx_exporter_system_group }} +ExecStart={{ nginx_exporter_binary_install_dir }}/nginx-prometheus-exporter \ + '--nginx.scrape-uri={{ nginx_exporter_scrape_uri }}' \ + '--web.listen-address={{ nginx_exporter_web_listen_address }}' \ + '--web.telemetry-path={{ nginx_exporter_web_telemetry_path }}' \ +{% if nginx_exporter_tls_server_config | length > 0 or nginx_exporter_http_server_config | length > 0 or nginx_exporter_basic_auth_users | length > 0 %} + '--web.config.file=/etc/nginx_exporter/web_config.yaml' \ +{% endif %} + '--log.level={{ nginx_exporter_log_level }}' \ + '--log.format={{ nginx_exporter_log_format }}' + +SyslogIdentifier=nginx_exporter +Restart=always +RestartSec=1 +StartLimitInterval=0 + +ProtectHome=yes +NoNewPrivileges=yes + +{% if (ansible_facts.packages.systemd | first).version is version('232', '>=') %} +ProtectSystem=strict +ProtectControlGroups=true +ProtectKernelModules=true +ProtectKernelTunables=yes +{% else %} +ProtectSystem=full +{% endif %} + +[Install] +WantedBy=multi-user.target diff --git a/roles/nginx_exporter/templates/web_config.yaml.j2 b/roles/nginx_exporter/templates/web_config.yaml.j2 new file mode 100644 index 000000000..1b805f5f9 --- /dev/null +++ b/roles/nginx_exporter/templates/web_config.yaml.j2 @@ -0,0 +1,18 @@ +--- +{{ ansible_managed | comment }} +{% if nginx_exporter_tls_server_config | length > 0 %} +tls_server_config: +{{ nginx_exporter_tls_server_config | to_nice_yaml | indent(2, true) }} +{% endif %} + +{% if nginx_exporter_http_server_config | length > 0 %} +http_server_config: +{{ nginx_exporter_http_server_config | to_nice_yaml | indent(2, true) }} +{% endif %} + +{% if nginx_exporter_basic_auth_users | length > 0 %} +basic_auth_users: +{% for k, v in nginx_exporter_basic_auth_users.items() %} + {{ k }}: {{ v | string | password_hash('bcrypt', ('abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890' | shuffle(seed=inventory_hostname) | join)[:22], rounds=9) }} +{% endfor %} +{% endif %} diff --git a/roles/nginx_exporter/test-requirements.txt b/roles/nginx_exporter/test-requirements.txt new file mode 100644 index 000000000..7f0b6e759 --- /dev/null +++ b/roles/nginx_exporter/test-requirements.txt @@ -0,0 +1 @@ +bcrypt diff --git a/roles/nginx_exporter/vars/main.yml b/roles/nginx_exporter/vars/main.yml new file mode 100644 index 000000000..87698f9ee --- /dev/null +++ b/roles/nginx_exporter/vars/main.yml @@ -0,0 +1,11 @@ +--- +go_arch_map: + i386: '386' + x86_64: 'amd64' + aarch64: 'arm64' + armv7l: 'armv7' + armv6l: 'armv6' + +go_arch: "{{ go_arch_map[ansible_architecture] | default(ansible_architecture) }}" +_nginx_exporter_repo: "nginxinc/nginx-prometheus-exporter" +_github_api_headers: "{{ {'GITHUB_TOKEN': lookup('ansible.builtin.env', 'GITHUB_TOKEN')} if (lookup('ansible.builtin.env', 'GITHUB_TOKEN')) else {} }}" From 9915604fa1bf061bffc205a2edcd641268f3d483 Mon Sep 17 00:00:00 2001 From: Oleg Klyuchkin Date: Thu, 8 Feb 2024 20:17:37 +0300 Subject: [PATCH 2/6] docs: fix default version in doc Signed-off-by: anviar --- roles/nginx_exporter/meta/argument_specs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/nginx_exporter/meta/argument_specs.yml b/roles/nginx_exporter/meta/argument_specs.yml index 0970f7f2f..5b3e9e394 100644 --- a/roles/nginx_exporter/meta/argument_specs.yml +++ b/roles/nginx_exporter/meta/argument_specs.yml @@ -10,7 +10,7 @@ argument_specs: options: nginx_exporter_version: description: "nginx_exporter package version. Also accepts latest as parameter." - default: "0.14.2" + default: "1.1.0" nginx_exporter_skip_install: description: "nginx_exporter installation tasks gets skipped when set to true." type: bool From b9c15a1bd23225e11eafbc5ca30016cf1149031f Mon Sep 17 00:00:00 2001 From: anviar Date: Fri, 9 Feb 2024 09:08:34 +0300 Subject: [PATCH 3/6] test: add ansible-test integration for nginx_exporter Signed-off-by: anviar --- .../targets/molecule-nginx_exporter-alternative/runme.sh | 4 ++++ .../targets/molecule-nginx_exporter-default/runme.sh | 4 ++++ .../targets/molecule-nginx_exporter-latest/runme.sh | 4 ++++ 3 files changed, 12 insertions(+) create mode 100755 tests/integration/targets/molecule-nginx_exporter-alternative/runme.sh create mode 100755 tests/integration/targets/molecule-nginx_exporter-default/runme.sh create mode 100755 tests/integration/targets/molecule-nginx_exporter-latest/runme.sh diff --git a/tests/integration/targets/molecule-nginx_exporter-alternative/runme.sh b/tests/integration/targets/molecule-nginx_exporter-alternative/runme.sh new file mode 100755 index 000000000..d094c3e1b --- /dev/null +++ b/tests/integration/targets/molecule-nginx_exporter-alternative/runme.sh @@ -0,0 +1,4 @@ +#!/usr/bin/env bash + +collection_root=$(pwd | grep -oP ".+\/ansible_collections\/\w+?\/\w+") +source "$collection_root/tests/integration/molecule.sh" diff --git a/tests/integration/targets/molecule-nginx_exporter-default/runme.sh b/tests/integration/targets/molecule-nginx_exporter-default/runme.sh new file mode 100755 index 000000000..d094c3e1b --- /dev/null +++ b/tests/integration/targets/molecule-nginx_exporter-default/runme.sh @@ -0,0 +1,4 @@ +#!/usr/bin/env bash + +collection_root=$(pwd | grep -oP ".+\/ansible_collections\/\w+?\/\w+") +source "$collection_root/tests/integration/molecule.sh" diff --git a/tests/integration/targets/molecule-nginx_exporter-latest/runme.sh b/tests/integration/targets/molecule-nginx_exporter-latest/runme.sh new file mode 100755 index 000000000..d094c3e1b --- /dev/null +++ b/tests/integration/targets/molecule-nginx_exporter-latest/runme.sh @@ -0,0 +1,4 @@ +#!/usr/bin/env bash + +collection_root=$(pwd | grep -oP ".+\/ansible_collections\/\w+?\/\w+") +source "$collection_root/tests/integration/molecule.sh" From 35b38bb93c7580bf82f4d66fae609c5a70b89f7c Mon Sep 17 00:00:00 2001 From: anviar Date: Fri, 9 Feb 2024 09:39:48 +0300 Subject: [PATCH 4/6] feat: add "Plus" mode flag for nginx_exporter Signed-off-by: anviar --- roles/nginx_exporter/defaults/main.yml | 1 + roles/nginx_exporter/meta/argument_specs.yml | 4 ++++ roles/nginx_exporter/templates/nginx_exporter.service.j2 | 3 +++ 3 files changed, 8 insertions(+) diff --git a/roles/nginx_exporter/defaults/main.yml b/roles/nginx_exporter/defaults/main.yml index 65d308931..71a9a5ba0 100644 --- a/roles/nginx_exporter/defaults/main.yml +++ b/roles/nginx_exporter/defaults/main.yml @@ -6,6 +6,7 @@ nginx_exporter_binary_url: "https://github.com/{{ _nginx_exporter_repo }}/releas nginx_exporter_checksums_url: "https://github.com/{{ _nginx_exporter_repo }}/releases/download/v{{ nginx_exporter_version }}/\ nginx-prometheus-exporter_{{ nginx_exporter_version }}_checksums.txt" nginx_exporter_skip_install: false +nginx_exporter_plus: false nginx_exporter_scrape_uri: "http://127.0.0.1/stub_status" nginx_exporter_web_listen_address: "0.0.0.0:9113" nginx_exporter_web_telemetry_path: "/metrics" diff --git a/roles/nginx_exporter/meta/argument_specs.yml b/roles/nginx_exporter/meta/argument_specs.yml index 5b3e9e394..43fc2c673 100644 --- a/roles/nginx_exporter/meta/argument_specs.yml +++ b/roles/nginx_exporter/meta/argument_specs.yml @@ -15,6 +15,10 @@ argument_specs: description: "nginx_exporter installation tasks gets skipped when set to true." type: bool default: false + nginx_exporter_plus: + description: "Start the exporter for NGINX Plus." + type: bool + default: false nginx_exporter_binary_local_dir: description: - "Enables the use of local packages instead of those distributed on github." diff --git a/roles/nginx_exporter/templates/nginx_exporter.service.j2 b/roles/nginx_exporter/templates/nginx_exporter.service.j2 index 8e0c5aafa..68650de46 100644 --- a/roles/nginx_exporter/templates/nginx_exporter.service.j2 +++ b/roles/nginx_exporter/templates/nginx_exporter.service.j2 @@ -14,6 +14,9 @@ ExecStart={{ nginx_exporter_binary_install_dir }}/nginx-prometheus-exporter \ '--web.telemetry-path={{ nginx_exporter_web_telemetry_path }}' \ {% if nginx_exporter_tls_server_config | length > 0 or nginx_exporter_http_server_config | length > 0 or nginx_exporter_basic_auth_users | length > 0 %} '--web.config.file=/etc/nginx_exporter/web_config.yaml' \ +{% endif %} +{% if nginx_exporter_plus %} + '--nginx.plus' \ {% endif %} '--log.level={{ nginx_exporter_log_level }}' \ '--log.format={{ nginx_exporter_log_format }}' From c7b2c604c4fd2e1c148cbdb09a1aa0958fb82fda Mon Sep 17 00:00:00 2001 From: anviar Date: Sat, 10 Feb 2024 09:00:48 +0300 Subject: [PATCH 5/6] refactor: change default user to custom Signed-off-by: anviar --- roles/nginx_exporter/defaults/main.yml | 4 ++-- roles/nginx_exporter/meta/argument_specs.yml | 4 ++-- .../nginx_exporter/molecule/default/tests/test_default.py | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/roles/nginx_exporter/defaults/main.yml b/roles/nginx_exporter/defaults/main.yml index 71a9a5ba0..79138ea9f 100644 --- a/roles/nginx_exporter/defaults/main.yml +++ b/roles/nginx_exporter/defaults/main.yml @@ -21,5 +21,5 @@ nginx_exporter_log_level: "info" nginx_exporter_log_format: "logfmt" nginx_exporter_binary_install_dir: "/usr/local/bin" -nginx_exporter_system_group: "nogroup" -nginx_exporter_system_user: "nobody" +nginx_exporter_system_group: "nginx-exp" +nginx_exporter_system_user: "{{ nginx_exporter_system_group }}" diff --git a/roles/nginx_exporter/meta/argument_specs.yml b/roles/nginx_exporter/meta/argument_specs.yml index 43fc2c673..e232c8f7d 100644 --- a/roles/nginx_exporter/meta/argument_specs.yml +++ b/roles/nginx_exporter/meta/argument_specs.yml @@ -67,9 +67,9 @@ argument_specs: description: - "I(Advanced)" - "System group for nginx_exporter" - default: "nogroup" + default: "nginx-exp" nginx_exporter_system_user: description: - "I(Advanced)" - "nginx_exporter user" - default: "nobody" + default: "nginx-exp" diff --git a/roles/nginx_exporter/molecule/default/tests/test_default.py b/roles/nginx_exporter/molecule/default/tests/test_default.py index 0720e119b..18339faee 100644 --- a/roles/nginx_exporter/molecule/default/tests/test_default.py +++ b/roles/nginx_exporter/molecule/default/tests/test_default.py @@ -30,10 +30,10 @@ def test_files(host): def test_user(host): - assert host.group("www-data").exists - assert "www-data" in host.user("www-data").groups - assert host.user("www-data").shell == "/usr/sbin/nologin" - assert host.user("www-data").home == "/" + assert host.group("nginx-exp").exists + assert "nginx-exp" in host.user("nginx-exp").groups + assert host.user("nginx-exp").shell == "/usr/sbin/nologin" + assert host.user("nginx-exp").home == "/" def test_service(host): From 672cad0253e90e404540891f66ee3e0f5b474c79 Mon Sep 17 00:00:00 2001 From: anviar Date: Sat, 10 Feb 2024 09:19:52 +0300 Subject: [PATCH 6/6] test: fix nginx_exporter checks Signed-off-by: anviar test: fix nginx_exporter alternative URI Signed-off-by: anviar test: fix nginx_exporter alternative locations Signed-off-by: anviar test: fix nginx_exporter alternative local bin directory Signed-off-by: anviar test: fix nginx_exporter alternative fix lint Signed-off-by: anviar test: fix nginx_exporter alternative local binary Signed-off-by: anviar test: fix nginx_exporter alternative fix port Signed-off-by: anviar --- .../molecule/alternative/molecule.yml | 2 +- .../molecule/alternative/prepare.yml | 26 +++++++++---------- .../alternative/tests/test_alternative.py | 2 +- .../molecule/latest/tests/test_latest.py | 2 +- 4 files changed, 15 insertions(+), 17 deletions(-) diff --git a/roles/nginx_exporter/molecule/alternative/molecule.yml b/roles/nginx_exporter/molecule/alternative/molecule.yml index 02be17c1b..4b42c1838 100644 --- a/roles/nginx_exporter/molecule/alternative/molecule.yml +++ b/roles/nginx_exporter/molecule/alternative/molecule.yml @@ -3,7 +3,7 @@ provisioner: inventory: group_vars: all: - nginx_exporter_binary_local_dir: "/tmp/nginx_exporter-linux-amd64" + nginx_exporter_binary_local_dir: "/tmp/nginx_exporter-linux-amd64_local" nginx_exporter_web_listen_address: "127.0.0.1:9113" nginx_exporter_tls_server_config: diff --git a/roles/nginx_exporter/molecule/alternative/prepare.yml b/roles/nginx_exporter/molecule/alternative/prepare.yml index b3c1f5e7d..95353ae73 100644 --- a/roles/nginx_exporter/molecule/alternative/prepare.yml +++ b/roles/nginx_exporter/molecule/alternative/prepare.yml @@ -6,9 +6,9 @@ - name: Download nginx_exporter binary to local folder become: false ansible.builtin.get_url: - url: "https://github.com/{{ _nginx_exporter_repo }}/releases/download/v{{ nginx_exporter_version }}/\ - nginx-prometheus-exporter-{{ nginx_exporter_version }}_linux-{{ go_arch }}.tar.gz" - dest: "/tmp/nginx_exporter-{{ nginx_exporter_version }}_linux-{{ go_arch }}.tar.gz" + url: "https://github.com/nginxinc/nginx-prometheus-exporter/releases/download/v{{ nginx_exporter_version }}/\ + nginx-prometheus-exporter_{{ nginx_exporter_version }}_linux_{{ go_arch }}.tar.gz" + dest: "/tmp/nginx-prometheus-exporter_{{ nginx_exporter_version }}_linux_{{ go_arch }}.tar.gz" mode: 0644 register: _download_binary until: _download_binary is succeeded @@ -16,20 +16,18 @@ delay: 2 check_mode: false + - name: Create local directory for binary + ansible.builtin.file: + path: "{{ nginx_exporter_binary_local_dir }}" + state: directory + mode: '0755' + - name: Unpack nginx_exporter binary become: false ansible.builtin.unarchive: - src: "/tmp/nginx_exporter-{{ nginx_exporter_version }}_linux-{{ go_arch }}.tar.gz" - dest: "/tmp" - creates: "/tmp/nginx_exporter-{{ nginx_exporter_version }}_linux-{{ go_arch }}/nginx_exporter" - check_mode: false - - - name: Link to nginx_exporter binaries directory - become: false - ansible.builtin.file: - src: "/tmp/nginx_exporter-{{ nginx_exporter_version }}_linux-amd64" - dest: "/tmp/nginx_exporter-linux-amd64" - state: link + src: "/tmp/nginx-prometheus-exporter_{{ nginx_exporter_version }}_linux_{{ go_arch }}.tar.gz" + dest: "{{ nginx_exporter_binary_local_dir }}" + creates: "{{ nginx_exporter_binary_local_dir }}/nginx-prometheus-exporter" check_mode: false - name: Install pyOpenSSL for certificate generation diff --git a/roles/nginx_exporter/molecule/alternative/tests/test_alternative.py b/roles/nginx_exporter/molecule/alternative/tests/test_alternative.py index d2cb881ef..9f1e8e7da 100644 --- a/roles/nginx_exporter/molecule/alternative/tests/test_alternative.py +++ b/roles/nginx_exporter/molecule/alternative/tests/test_alternative.py @@ -39,7 +39,7 @@ def test_protecthome_property(host): def test_socket(host): sockets = [ - "tcp://127.0.0.1:8080" + "tcp://127.0.0.1:9113" ] for socket in sockets: s = host.socket(socket) diff --git a/roles/nginx_exporter/molecule/latest/tests/test_latest.py b/roles/nginx_exporter/molecule/latest/tests/test_latest.py index fbac26344..6dffb2c40 100644 --- a/roles/nginx_exporter/molecule/latest/tests/test_latest.py +++ b/roles/nginx_exporter/molecule/latest/tests/test_latest.py @@ -11,7 +11,7 @@ @pytest.mark.parametrize("files", [ "/etc/systemd/system/nginx_exporter.service", - "/usr/local/bin/nginx_exporter" + "/usr/local/bin/nginx-prometheus-exporter" ]) def test_files(host, files): f = host.file(files)