Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-postgres-exporter] Multi Target Bug #5106

Open
emily-ganze opened this issue Dec 30, 2024 · 0 comments
Open

[prometheus-postgres-exporter] Multi Target Bug #5106

emily-ganze opened this issue Dec 30, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@emily-ganze
Copy link

Describe the bug a clear and concise description of what the bug is.

With prometheus-postgres-exporter.serviceMonitor.multipleTarget.enabled = true, DATA_SOURCE_URI is still being set via .Values.config.datasource which is not used by the multipleTarget feature.

What's your helm version?

version.BuildInfo{Version:"v3.10.1", GitCommit:"9f88ccb6aee40b9a0535fcc7efea6055e1ef72c9", GitTreeState:"clean", GoVersion:"go1.19.2"}

What's your kubectl version?

Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.4", GitCommit:"872a965c6c6526caa949f0c6ac028ef7aff3fb78", GitTreeState:"clean", BuildDate:"2022-11-09T13:28:30Z", GoVersion:"go1.19.3", Compiler:"gc", Platform:"darwin/arm64"} Kustomize Version: v4.5.7 Server Version: version.Info{Major:"1", Minor:"31", GitVersion:"v1.31.3-eks-56e63d8", GitCommit:"7a5334cf6c02f054f69ceef6698ffa059441b7c9", GitTreeState:"clean", BuildDate:"2024-12-03T17:52:44Z", GoVersion:"go1.22.8", Compiler:"gc", Platform:"linux/amd64"} WARNING: version difference between client (1.25) and server (1.31) exceeds the supported minor version skew of +/-1

Which chart?

prometheus-postgres-exporter

What's the chart version?

6.8.1

What happened?

env variable name: DATA_SOURCE_URI, value: ':5432/?sslmode=disable' caused connection errors.

What you expected to happen?

postgres exporter should use the values in the service monitor + config map to connect to the db's not the DATA_SOURCE_URI env var.

How to reproduce it?

use values listed below

Enter the changed values of values.yaml?

serviceMonitor:
enabled: true
multipleTarget:
enabled: true
targets:
- endpoint: connectionstring-one
name: one
databaseName: one
- endpoint: connectionstring-two
name: two
databaseName: two

config:
postgresExporter: |
auth_modules:
one:
type: userpass
userpass:
username: something
password: anotherthing
two:
type: userpass
userpass:
username: something
password: anotherthing

Enter the command that you execute and failing/misfunctioning.

helm install -f ./postgres-exporter/values.yaml -f ../../base/postgres-exporter.yaml postgres-exporter ./postgres-exporter

Anything else we need to know?

No response

@emily-ganze emily-ganze added the bug Something isn't working label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant