Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment Methods fields has no options. #3

Open
kjtolsma opened this issue Feb 28, 2024 · 4 comments
Open

Payment Methods fields has no options. #3

kjtolsma opened this issue Feb 28, 2024 · 4 comments
Assignees

Comments

@kjtolsma
Copy link
Member

If i enable the plugin and add the "Payment Methods" field it has no options. In the form i can't select a Payment Method.

payment-methods
@remcotolsma remcotolsma self-assigned this Mar 4, 2024
@remcotolsma remcotolsma moved this to Todo in Pronamic Pay Mar 4, 2024
@rvdsteege
Copy link
Member

This is probably caused by no 'Collect Payment' action being added to the form yet:

https://github.com/pronamic/wp-pronamic-pay-ninjaforms/blob/4d1cd150afdb2b3d62c91de356b97e3d903654e6/src/PaymentMethodsField.php#L146-L158

@remcotolsma
Copy link
Member

remcotolsma commented Mar 4, 2024

That is indeed correct, specifically no "Collect Payment" actions with the "Pronamic Pay" gateway:

https://github.com/pronamic/wp-pronamic-pay-ninjaforms/blob/4d1cd150afdb2b3d62c91de356b97e3d903654e6/src/NinjaFormsHelper.php#L38-L64

And if there is a "Collect Payment" actions with the "Pronamic Pay" gateway for the relevant form, there must also be a Pronamic Pay gateway configuration available:

https://github.com/pronamic/wp-pronamic-pay-ninjaforms/blob/4d1cd150afdb2b3d62c91de356b97e3d903654e6/src/NinjaFormsHelper.php#L92-L110

This actually brings us back to the next issue:

Should we simplify this by working with one general list of active payment methods within a site?

I had already experimentally added options for this in the past:

@rvdsteege
Copy link
Member

Should we simplify this by working with one general list of active payment methods within a site?

@remcotolsma If there is no configuration added yet and therefore no payment methods enabled yet, would a payment method field then have any options or is still empty as in @kjtolsma his original post?

@remcotolsma
Copy link
Member

If there is no configuration added yet and therefore no payment methods enabled yet

The configuration is not per se relevant if we have a general list of payment methods with a status. Without configuration, payment methods can be active, we can give a number of commonly used payment methods the status 'active' by default. This way, the payment method field can be filled with the standard payment method options. Whether paying via those payment methods works will of course depend on the configuration later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants