add tests for url generation

[eads]

No description provided.

[alesage]

A friend directed me to the ProPublica article and I'd like to pitch in; would you provide a little more info on this issue?

[eads]

Hey @alesage! That's fantastic.

Here's the deal: I'm working on getting the public facing version of this out the door in the next few weeks with a minimum viable product coming next week ahead of publishing the public facing app.

I'll ping you once that's done and we can get into this a bit more deeply. There's a couple other contributors I need to circle back with as well.

In the short term, please fork the repo to make pull requests and check out https://github.com/propublica/cookcountyjail2/blob/master/jailscraper/spiders/inmate_spider.py#L62-L81, specifically line 67. It's trivial, but we should factor line 67 into a small function and then write a test to ensure it's properly generating URLs. I'm quite sure it is, so this is really about testing for regressions and future proofing in case the url scheme changes.

[alesage]

Agree that this is small but the effect was just to introduce me to the codebase, I have some spare cycles if more is needed? Else I'll look forward to some circling-back.