Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom token bridging #206

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Add support for custom token bridging #206

wants to merge 21 commits into from

Conversation

rpanic
Copy link
Member

@rpanic rpanic commented Oct 11, 2024 •
edited
Loading

Closes #202

Depends on #200

This PR implements the core design of the above spec, along with some refactoring and restructurings that were needed for this.

  • Added BridgeContract as reusable contract that acts the token holder for bridged assets and facilitates/validates withdrawals
  • Modifies the Withdrawals runtime module to support multiple tokens
  • Added Authorizations as per spec
  • Added compile() to ContractModule so that the SettlementProvingTask has no hardcoded dependencies anymore
  • Added BridgingModule that facilitates transaction generation for bridging operations

TODOs left:

  • Add a task that compile the bridge contract and generates it's VK, so that we can then use it as a baked-in value in the SettlementContract (SettlementModule:397) edit: Covered as part of the enable proving PRs

@rpanic rpanic marked this pull request as ready for review October 11, 2024 15:09
@maht0rz maht0rz changed the base branch from refactor/smart-contract-modularity to develop October 30, 2024 11:10
rpanic added 2 commits October 30, 2024 12:43
@rpanic
Merge branch 'develop' into feature/custom-token-bridging
059b378 
# Conflicts:
#	package-lock.json
#	packages/library/src/runtime/Withdrawals.ts
#	packages/sequencer/test/settlement/Settlement.ts
@rpanic
package-lock
27938dc
rpanic
rpanic commented Oct 30, 2024
View reviewed changes
.nvmrc
v22.9.0
Copy link
Member Author

@rpanic rpanic Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one, v18 leads to very bad performance on apple silicon, maybe we can use v20 though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for custom token bridging
1 participant
@rpanic