Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to deal with transaction where the tx hooks fail #217

Open
rpanic opened this issue Oct 30, 2024 · 0 comments
Open

Figure out how to deal with transaction where the tx hooks fail #217

rpanic opened this issue Oct 30, 2024 · 0 comments

Comments

@rpanic
Copy link
Member

rpanic commented Oct 30, 2024

Currently, if a transaction is included in a block but one of the transaction hooks fails, we skip the transaction in that block, but it won't get removed from the mempool. This leads to the transaction being applied (and failing) again and again, for some users that is unwanted behaviour.

We need to figure out how to deal with that, especially also in the context that transaction might become valid in the future. For example, the nonce might be too large for a particular account, but if another transaction with the right nonce comes along, the transaction might become valid again.
For this case, we might keep them in the mempool for the future, but we need to distinguish them from transactions that will never be valid, or ones that we want to throw out regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant