Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created transactions on Database to do atomic writes for blocks, results and batches #233

Open
wants to merge 2 commits into
base: fix/atomic-block-production
Choose a base branch
from
Open

Created transactions on Database to do atomic writes for blocks, results and batches #233

wants to merge 2 commits into from

Conversation

rpanic
Copy link
Member

@rpanic rpanic commented Nov 22, 2024

Closes #231

@rpanic rpanic requested a review from maht0rz November 22, 2024 17:43
@maht0rz
Copy link
Member

maht0rz commented Nov 25, 2024

Can we add a test that demonstrates the issue that led to this fix?

@rpanic rpanic force-pushed the fix/atomic-block-production-db branch from bb74c44 to dfab89c Compare November 26, 2024 09:38
@rpanic
Copy link
Member Author

rpanic commented Nov 26, 2024

Test added, pls re-review @maht0rz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maht0rz maht0rz Awaiting requested review from maht0rz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpanic @maht0rz