Fix for Mempool and BP using different State Services #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A community member reported seeing an issue where a tx was stuck in pending, i.e. never included in a block. This was because when a block is produced it checks to see if a tx is valid, which involves checking the nonce (amongst other things). A previous tx had already been sent from the same sender, but this was not being noticed by the BP and so expected the tx in the mempool to have nonce 0, rather the the correct nonce of 1, which it in fact had. Consequently, the tx was never picked up and just sat there in the mempool.