-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TargetRadius 0 on Android doesnt overlay nested components #78
Comments
@danieljgp2 i think you can just use it. It's open. |
@witalobenicio it work partially, still not working as it should. Any idea about how to solve it? |
You are already using my PR? |
@witalobenicio yes, the problem seems to be related with the change of forView for forBounds, using your pr the component inside of the touchableOpacity with a TargetRadius 0 overlays the outercircle but it freeze the javascript after a while |
Yeah... I use forView and seems to work just fine in my app. |
Using for view doesnt break the title and the description of the tour? |
Nope. It work just fine. |
If you have a component that you want to highlight...maybe the highlight may have to go to the view inside the component. |
Is there a way to use your fork as a dependency? It is the first time i have this kind of issue, i Just took your fork and insert it on node module react native app tour 😁 |
Yes. react-native-app-tour: And you can add with yarn too: yarn add react-native-app-tour@ |
Thanks for answering wita, still having the problem on my project, even with your fork. |
Maybe on Sunday I can help you. I'll be back from vacation. |
@witalobenicio how can i contact with you? |
@danieljgp2 lets talk by direct message on twitter. It's the same '@' of GitHub. |
@witalobenicio Already send you a Twit. Check it out |
@witalobenicio You set collapsable false to the view inside the TouchableOpacity that is setted as the appviewtarget or to the appviewtarget itself ? |
@witalobenicio Im using your fork and it seems to work fine, but when i change from a tab view to another one, opening the tour again freezes the app, it is like the tour is called but not displayed, this doesnt happen when i use forBounds, but with forBounds i have the problem that i just wrote above. |
@danieljgp2 if you try the same with the default project it works? |
@witalobenicio it is working for now, i did a fork and change the forBounds for the forViews, the problem is totally related with this change. |
@prscX on iOS when I set TargetRadius on 0 and I have a nested component, the nested componente showns overlay on the outercircle, this doesnt happens on Android.
On Android the nested component is under the outher circle and if I set targetTransparent it Just overlay the content inside the target.
This is how it looks on android with targetRadius on 0
This is how it looks on iOS with targetRadius on 0
The text was updated successfully, but these errors were encountered: