Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TargetRadius 0 on Android doesnt overlay nested components #78

Open
danieljgp2 opened this issue Aug 30, 2019 · 19 comments
Open

TargetRadius 0 on Android doesnt overlay nested components #78

danieljgp2 opened this issue Aug 30, 2019 · 19 comments
Assignees

Comments

@danieljgp2
Copy link

danieljgp2 commented Aug 30, 2019

@prscX on iOS when I set TargetRadius on 0 and I have a nested component, the nested componente showns overlay on the outercircle, this doesnt happens on Android.

On Android the nested component is under the outher circle and if I set targetTransparent it Just overlay the content inside the target.

This is how it looks on android with targetRadius on 0
Captura de Pantalla 2019-08-30 a la(s) 14 51 40

This is how it looks on iOS with targetRadius on 0
Captura de Pantalla 2019-08-30 a la(s) 14 50 39

@witalobenicio
Copy link

@danieljgp2 i think you can just use it. It's open.

@danieljgp2
Copy link
Author

@witalobenicio it work partially, still not working as it should. Any idea about how to solve it?

@witalobenicio
Copy link

You are already using my PR?

@danieljgp2
Copy link
Author

@witalobenicio yes, the problem seems to be related with the change of forView for forBounds, using your pr the component inside of the touchableOpacity with a TargetRadius 0 overlays the outercircle but it freeze the javascript after a while

@witalobenicio
Copy link

Yeah... I use forView and seems to work just fine in my app.
I don't use forBounds.

@danieljgp2
Copy link
Author

Using for view doesnt break the title and the description of the tour?

@witalobenicio
Copy link

Nope. It work just fine.
I don't have the code here to show to you cause I'm on vacations...but as far as I know...it's all good.
You just have to be careful of where you are using. When you use in deep views it doesn't work so nice.
And remember to set collapsable to false.

@witalobenicio
Copy link

If you have a component that you want to highlight...maybe the highlight may have to go to the view inside the component.
Got it?

@danieljgp2
Copy link
Author

Is there a way to use your fork as a dependency? It is the first time i have this kind of issue, i Just took your fork and insert it on node module react native app tour 😁

@witalobenicio
Copy link

Yes.
When you do a fork, you create a new repo in your own account.
So, for you to use my fork, you just have to add my repo url as a dependency.

react-native-app-tour:

And you can add with yarn too:

yarn add react-native-app-tour@

@danieljgp2
Copy link
Author

Thanks for answering wita, still having the problem on my project, even with your fork.

@witalobenicio
Copy link

Maybe on Sunday I can help you. I'll be back from vacation.

@danieljgp2
Copy link
Author

@witalobenicio how can i contact with you?

@witalobenicio
Copy link

@danieljgp2 lets talk by direct message on twitter. It's the same '@' of GitHub.

@danieljgp2
Copy link
Author

@witalobenicio Already send you a Twit. Check it out

@danieljgp2
Copy link
Author

@witalobenicio You set collapsable false to the view inside the TouchableOpacity that is setted as the appviewtarget or to the appviewtarget itself ?

@danieljgp2
Copy link
Author

@witalobenicio Im using your fork and it seems to work fine, but when i change from a tab view to another one, opening the tour again freezes the app, it is like the tour is called but not displayed, this doesnt happen when i use forBounds, but with forBounds i have the problem that i just wrote above.

@witalobenicio
Copy link

@danieljgp2 if you try the same with the default project it works?
Maybe @prscX could help better on this one.

@danieljgp2
Copy link
Author

@witalobenicio it is working for now, i did a fork and change the forBounds for the forViews, the problem is totally related with this change.

@prscX prscX self-assigned this Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants