gcode: Fix issue on unloaded filament temperature being higher temperature than loaded filament (lower temperature) #3681

We don't have consent from the user right now and they are not encrypted. Shouldn't go to "production". BFW-3468.

…sure getting the filament out of the gear)

Dialog stores the state of underlying screen upon construction and loads it back upon destruction. Consistently. Like, always. Without this, ToolBox::DialogToolActionBox would set focused item which would prevent menu screen from serializing its focused item.

BFW-5178

BFW-5138.

Allow them in redscreen/redscreen. It's already sent proactively, so it's safe. BFW-5207.

Show Enclosure menu only if enclosure is active Change string describing invalid temperature from "N/A" to "--"

Transfers were not cleaned up ever, if in print preview when finished, this was caused by wrongly detecting if the transfer is in progress. It did not check, if the backup file was there, do transfer, where backup file was not present (finished) were taken as in progress.

Not shown / used anywhere. But counts them, so we can use them later on. BFW-5138.

BFW-5138.

After the user does the cleaning of the extruder, this is where they can reset the reminder. BFW-5138.

BFW-5138

Re-integrate the missing mini-step before we recompute the absolute origin, as previously done.

Always try to preserve the step fraction, except when: - reinitializing from scratch (no step fraction exists) - after rehoming (position is assumed to be absolute) This now includes the special case when a move is interrupted: if a move involving only one axis is interrupted, we would previously loose the fraction for all axes. Since the generator state is ticking ahead, keep a new flag to keep track of the axis state of all moves. Use this flag during reset to keep the fraction when the axis hasn't actually moved, meaning we can perform carry-over.

Given: - total_start_pos is now absolute and initialized from the counters, and - step_generator_state.current_distance is the integer distance added so far to the counters already in physical units, and - total_start_pos_msteps is actually current_distance + fraction it follows we can avoid reconstructing current_distance from the move, which incurs in extra rounding, but instead we can directly use the stepper counters and leave total_start_pos_msteps unchanged when resetting while preserving the fraction.

... marginally makes the code more readable

Always discard the fraction

since we reset msteps.e and completely ignore the absolute position for the extruder.

There are four loop_load and four loop_unload functions with almost identical implementation, so we had duplicit code that was a PITA to maintain. This commit unifies most of the functions, there are still some less-similar smaller ones that can be unified in the future. Prerequisity for BFW-5043 and BFW-5142

BFW-5142

…onable

BFW-5043

BFW-5142 BFW-5043

BFW-3704

Update POT file

Put the final wording to the proper places. BFW-4858

subrepo: subdir: "lib/Prusa-Error-Codes" merged: "2a53dd19f" upstream: origin: "[email protected]:prusa3d/Prusa-Error-Codes.git" branch: "master" commit: "7ff976755" git-subrepo: version: "0.4.6" origin: "https://github.com/ingydotnet/git-subrepo" commit: "110b9eb"

- Accept CLICK_BUTTON event - Parse the response - Validates the dialog_id is still relevant - Selects top FSM, validates the dialog_id and response for that FSM/phase and sends that Response

Newly it gurantees, that we only send dialogs from the top FSM. So we don't have to do any gymnastics around determining for which FSM is the click meant and just check dialog_id and if it matches it must be for top FSM. Also the state detection and dialog generation are handled seperatly, which in theory makes it clearer. It introduces some similarities in the logic in both places, but I'd say it is worth it, because otherwise it was quiet messy and would be hard to guarantee to always send top FSM dialog.

After discussion with connect we decided to rename the command from CLICK_BUTTON to DIALOG_ACTION and the field "response" to "button". On top of that just a couple changed in code names, so that it is consistent.

BFW-5238

BFW-5050

BFW-5029

It is eating a bunch of different resources (we are discovering more and more). BFW-5183.

Apparently, mdns introduces bunch of timeouts, but didn't remove them on removal of the interface. This resulted in two Bad Things: * Hogging the timeouts. * Having dangling pointers in them. BFW-5183.

BFW-5183.

* Adjust for only one interface with MDNS instead of both. * Adjust for 5 more discovered timeouts per each interface :-( BFW-5183.

BFW-5029

We're anticipating that we might want to limit it in stealth mode. BFW-5029

BFW-5029

Does nothing for now, funcitonality will be added later BFW-5029

BFW-5029

BFW-5035

BFW-5152

Some menu items were not adhering to the casing standard. Some also had colons at the end. BFW-5266

BFW-5219

BFW-5220

prusa.io/mmu-maintenance -> prusa.io/mmu-care, as requested by Content BFW-5232.

BFW-5270

BFW-5264

subrepo: subdir: "lib/Prusa-Error-Codes" merged: "895dd5705" upstream: origin: "[email protected]:prusa3d/Prusa-Error-Codes.git" branch: "master" commit: "895dd5705" git-subrepo: version: "0.4.6" origin: "https://github.com/ingydotnet/git-subrepo" commit: "73a0129"

Those texts are needed in the yaml for connect to show them, when we send the codes. Take them from there even for dialogs, so that they are not in two places nad out of sync.

BFW-5219

It screws up things - for example it resets weight compensation. BFW-5251

BFW-5251

input_shaper module cannot be touched from the displayTask! This was causing BSODs! Instead, we adjust the settings in the config store and issue a gcode that instructs the input_shaper to reload settings. BFW-5251

Seems like there happened some hash conflict and we got translated something we didn't want to. BFW-5246

BFW-5246

BFW-5263

BFW-5199

The extinction of old forms is the almost inevitable consequence of the production of new forms. BFW-5215

BFW-5215

Ditch smart queues and dumb queues. Have the FSM state as the Marlin variable. Let the clients do the thinking. BFW-5215

Forgot to lock for this one and disabling link from menu is something not many people do.

BFW-5231

- don't commit changes, when it did not really changed, it was causing a change in the fsm generation and screwed up connect clicking - send load unload data, not printing data to GetResponses in printer state

PrusaPackGcodeReader has a move constructor/operator. stream_t::hs_decoder was unsafely moved around, potentially causing a memory corruption. BFW-5274

BFW-5274

BFW-5279

BFW-5281

BFW-5230.

BFW-5282 BFW-4997

As a special exception we do not close PrintPreview screen when the LoadUnload dialog is requested. It would destroy the ToolsMappingBody while one of its methods is still executing, leading to calling refresh_physical_tool_filament_labels() which in turn jumped to undefined memory.

After successful cold-pull, there is no fillament loaded anymore and we need to manually set the fillament as unloaded. BFW-5304

The reset pin was floating. Also some timing adjustments. BFW-5286

This error happens when the MMU is switching between the bootloader and firmware - it gives up the control over the TX and the Mk4 UART RX gets pulled down, which causes a frame error. It gets pulled down because of the new pulldown R214 resistor on the xBuddy. BFW-5286

BFW-5286

BFW-5305

No need to pointlessly use up the processor BFW-5213

Quite complex to explain why - please read the comments in the BFW-5213. Basically, it gets called inside Tmr Svc during usb recovery, but Tmr Svc cannot be blocking (by spec). BFW-5213

BFW-5310

…e/relative positioning

To fit the upcoming stealth icon :) BFW-5313

BFW-5313

During selftest, a LoadUnload can be issued. Before, the score of LoadUnload FSM was the same, so the dialog was not shown. BFW-5321

BFW-5321

The "Is filament unloaded" was showing right after user pressed on "unload", without waiting for the unload dialog to finish. It blinked a bit. BFW-5321

Feels like it should be replaceable by checking if a dialog is open via GetFirstDialog() BFW-5321

BFW-5329

To make Sensor Info -> Filament Sensor raw value display 0 and 1. BFW-5337

When the Nextruder hasn't been reworked into the MMU variant (i.e. Settings->HW->Nextruder is not MMU) -> do not show the "Nextruder maintenance" menu item. BFW-5325

Make stream restore info not PrusaPack only, which saves us some ugly ifs and makes the interface cleaner. BFW-5329

BFW-5329

This should fix BSODs found by BFW-5329 & BFW-5274

BFW-5321

Fix need for double turn on of the MMU (flip_mmu_rework turns on MMU) Fix first print on fresh printer - properly set up logical/physical FS on MMU turn on/off

BFW-5344

The original implementation: - used dynamic allocation - did not lock the mutex on the first instantiation (get_handle was called before init_mutexes) - relied on hi2c.Instance, which was null before I2C initialization - had duplicit code (mutex inicialization) The code is still ugly, but hopefully at least a bit better. BFW-5274

Checking for the I2C handle was not enough. For example, the handle gets unlocked on I2C reinit, which kind of ruins things... BFW-5274

BFW-5313

The valued that is moved from is invalidated to not reset values at the end of its lifetime. BFW-5322

This should prevent noices when calibration X axis on XL and improve Tool Offset Calibrations, but only when run as part of selftest, not as gcode (will be done in separate commit/PR) BFW-5322

Small code cleanup. BFW-5322

BFW-5322

We shouldn't run any selftest with phasestepping enabled. To prevent running G425 with phase stepping we are disabeling phasestepping temporarily in the gcode it self instead of the selftest state machine. This improves Tool Offset Calibration results when running said calibration on already calibrated machine. The results are not perfect yet. But this change removes the major inaccuracies in the measurements. BFW-5276

We noticed shifts in measured data. Recomend reading BFW-5276 for more details, but in the end slowing down the parking speed helped a lot. BFW-5276

BFW-5335

Fill will be in the next commit BFW-5335

BFW-5335

The problem was in write_end_item calling migrate_bank. The function is called in store init, where migrate_bank would screw things. In other cases, the free space for the end item is checked in the parent calling functions. BFW-3553

…sensor_and_user_push__ask BFW-5361

This reverts commit f605a28bea662f02ec8d5121f4f57cee8ada774b.

BFW-5297

Copy pasted from standard printing screen BFW-5371

BFW-5305

BFW-5372

BFW-5346

BFW-5373

…d than filament on load

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gcode: Fix issue on unloaded filament temperature being higher temperature than loaded filament (lower temperature) #3681

gcode: Fix issue on unloaded filament temperature being higher temperature than loaded filament (lower temperature) #3681

Commits on Mar 28, 2024

Commits on Apr 11, 2024

Commits on Apr 16, 2024

Commits on Apr 22, 2024

Commits on Apr 23, 2024

Commits on Apr 24, 2024

Commits on Apr 28, 2024

gcode: Fix issue on unloaded filament temperature being higher temperature than loaded filament (lower temperature) #3681

Are you sure you want to change the base?

gcode: Fix issue on unloaded filament temperature being higher temperature than loaded filament (lower temperature) #3681

Commits on Mar 28, 2024

Commits on Apr 11, 2024

Commits on Apr 16, 2024

Commits on Apr 22, 2024

Commits on Apr 23, 2024

Commits on Apr 24, 2024

Commits on Apr 28, 2024