Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger timeout truncated to 8 bit (pxarCore) #449

Open
piberger opened this issue Sep 20, 2018 · 0 comments
Open

Trigger timeout truncated to 8 bit (pxarCore) #449

piberger opened this issue Sep 20, 2018 · 0 comments
Labels
HAL

Comments

@piberger
Copy link
Contributor

The value for trigger timeout in clocks which is passed here:
https://github.com/psi46/pxar/blob/master/core/hal/hal.cc#L211
is a uint8_t, which leads to truncated events marked as PKAM and unwanted resets for events with ~40 or more hits.
It should be 16 bit instead.
@piberger piberger added the HAL label Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HAL
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@piberger