Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure formatting toolbars on comments appear in all variations #8475

Closed
7 tasks
Sagarpreet opened this issue Oct 7, 2020 · 1 comment
Closed
7 tasks

Ensure formatting toolbars on comments appear in all variations #8475

Sagarpreet opened this issue Oct 7, 2020 · 1 comment
Labels
feature explains that the issue is to add a new feature

Comments

@Sagarpreet
Copy link
Contributor

Quoting @jywarren from publiclab/PublicLab.Editor#490 (comment)

basically, the comment editor sometimes shows a formatting bar (when it's for a question) but sometimes doesn't (for comments on non-questions). The actual toolbar code is here: https://github.com/publiclab/plots2/blob/bbfd7d4431ea7fbf36ab020015af0699606b3847/app/views/editor/_toolbar.html.erb

The other issue is that when submitting a comment, new comment forms are inserted with AJAX, and they may or may not have the toolbar. What we're looking for is for all comment boxes to have the toolbar, consistently. Let's move this all into its own issue and we can plan it out?

TODO:

Make sure that toolbar is always there in comment editor in following scenarios:

  • reply to comment
  • comment just posted (form inserted via AJAX)
  • reply to comment just posted
  • editing existing comments
  • editing comments just posted
  • editing comment replies
  • editing comment replies just posted

Files where we may have to solve this:

  1. https://github.com/publiclab/plots2/blob/bbfd7d4431ea7fbf36ab020015af0699606b3847/app/views/editor/_toolbar.html.erb
  2. https://github.com/publiclab/plots2/blob/bbfd7d4431ea7fbf36ab020015af0699606b3847/app/views/comments/_form.html.erb
  3. https://github.com/publiclab/plots2/blob/bbfd7d4431ea7fbf36ab020015af0699606b3847/app/assets/javascripts/comment.js
@Sagarpreet Sagarpreet added the feature explains that the issue is to add a new feature label Oct 7, 2020
@welcome
Copy link

welcome bot commented Oct 7, 2020

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature explains that the issue is to add a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants