Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not properly hashing class based objects getters #120

Open
piranna opened this issue Jan 12, 2023 · 0 comments · May be fixed by #121
Open

Not properly hashing class based objects getters #120

piranna opened this issue Jan 12, 2023 · 0 comments · May be fixed by #121

Comments

@piranna
Copy link

piranna commented Jan 12, 2023

When hashing a (class based) object with a getter, object-hash try to get the actual property value, while in fact it's calculated. So when doing it with ws WebSocket class, it goes to its prototype and finally to the extensions getter, throwsing an exception because this._extensions is undefined since its initialized in its constructor. Here we have several alternatives:

  • consider the exception as the property value, and serialize it
  • swallow the exception, and ignore the property
  • detect it's a property getter with getOwnPropertyDescriptor, and serialize its function with a getter: prefix

I think the best option is the last one, since it's the most attached to the code. Since we are using Object.keys(), there would not be overlap with getters set at prototype or class level, and the place to check and serialize the getter with the getter: prefix and the serialized getter function object should be in place of fetching its value when accesing to the object attributes values.

I think this issue can be related to #49, #81, #84, and #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant