Incorrect hash for array with multiple elements that refer to the same object

[everhardt]

I would expect objectHash(b) === objectHash(c) for

const a = [1, 2];
const b = [[1, 2], [1, 2]];
const c = [a, a];

That's not the case. See https://codepen.io/everhardt/pen/PvYPvp for an example.

[addaleax]

This is intentional – b[0] !== b[1] but c[0] === c[1], so the objects are considered different. I’d like to avoid making breaking changes to this project, and this would definitely be a breaking change.

[everhardt]

Maybe an option flag respectReferences defaulting to true could be an option? Right now I resort to JSON.parse(JSON.stringify(object)), but that's a bit expensive.

[addaleax]

@everhardt It’s not trivial to implement this in a way so that this still works for objects with circular references – but yes, a PR would be welcome.

[everhardt]

I understand

…

On Fri, 3 May 2019 at 16:17, Anna Henningsen ***@***.***> wrote: @everhardt <https://github.com/everhardt> It’s not trivial to implement this in a way so that this still works for objects with circular references – but yes, a PR would be welcome. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#78 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOBIGPHLLS5C4R4Y5RPZVTPTRCQTANCNFSM4HKUHWWA> .

[h0od]

This issue made me leave this lib in favor for node-object-hash instead, which doesn't have this issue.