Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container remote upstream name option #1685

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

stejoo
Copy link
Contributor

@stejoo stejoo commented Jul 2, 2024

The example code to create a container remote contains an argument that is incorrect:

Error: No such option: --upstream_name (Possible options: --upstream-name, --username)

This commit modifies the underscore in the argument to a hyphen. That resolves the "No such option" error.

@lubosmj
Copy link
Member

lubosmj commented Jul 2, 2024

Thanks for opening this PR! Would you mind also adding [noissue] to the commit description to make the CI green, please?

@stejoo
Copy link
Contributor Author

stejoo commented Jul 2, 2024

I modified the commit message. Is this what you had in mind? 😄

@lubosmj
Copy link
Member

lubosmj commented Jul 2, 2024

Kind of. But, we can accept it as it is. 🪂

A description is not a commit message. For example, see this commit: e52fa5d. It was created like:

git commit -m "Update CI" -m "[noissue]"

@stejoo
Copy link
Contributor Author

stejoo commented Jul 2, 2024

Ah. You prefer it in the commit message body instead of title. Got it. Hold on. 😉

The example code to create a container remote contains an argument that is incorrect:

> Error: No such option: --upstream_name (Possible options: --upstream-name, --username)

This commit modifies the underscore in the argument to a hyphen. That resolves the "No such option" error.

[noissue]
@lubosmj lubosmj enabled auto-merge (rebase) July 2, 2024 12:23
@lubosmj lubosmj merged commit 2d7b93c into pulp:main Jul 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants