Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert changes to match 1.6.3, apart of resume on restart #64

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

b0dea
Copy link
Collaborator

@b0dea b0dea commented Nov 19, 2024

@code-xhyun this is my last try to get 'nextRunAtset onnull` fixed.

As a note, on 1.6.3 - it works, nextRunAt gets set up correctly.

So 100% some of my changes are buggy.
With this change, I see no other differences between this and 1.6.3 - apart of the resumeOnRestart method which should not affect anything else.

So

  • please take a look and see if we should change anything else. Ideally run it yourself also, maybe it's something wrong on my side.
  • if you have no time - I am going to forward my apologize for the mistake(s) and I ask you to please revert all back to 1.6.3 which will keep all the original issues, but at least nextRunAt works as expected (tested myself). Like this we avoid making people use the buggy version.

I am sorry for this. Thank you.

@code-xhyun code-xhyun merged commit b982e06 into pulsecron:main Nov 19, 2024
1 check passed
@code-xhyun
Copy link
Contributor

🎉 This PR is included in version 1.6.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@code-xhyun
Copy link
Contributor

Thx bro :) @b0dea

@b0dea b0dea deleted the revert-once-changes branch November 19, 2024 12:18
@b0dea
Copy link
Collaborator Author

b0dea commented Nov 19, 2024

Thx bro :) @b0dea

@code-xhyun I can confirm now that the issue is no longer present. I will work these days on improving the bit even more the resumeOnRestart and will look more into the default date so we avoid re-running randomly the non-recurrent jobs. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants