Fix flaky TestFindOlderVersions due to gofakeit noun collision

pulumi · Mar 28, 2024 · ef9da91 · ef9da91
1 parent e153154
commit ef9da91
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/provider/pkg/versioning/findOlderVersions.go b/provider/pkg/versioning/findOlderVersions.go
@@ -1,6 +1,7 @@
 package versioning
 
 import (
+	"log"
 	"sort"
 
 	"github.com/pulumi/pulumi-azure-native/v2/provider/pkg/openapi"
@@ -18,6 +19,9 @@ func findOlderVersions(specVersions ProvidersVersionResources, defaultVersion op
 				continue
 			}
 			olderVersions = append(olderVersions, version)
+			if len(olderVersions) > 1 {
+				log.Println("whaaa")
+			}
 		}
 		sort.Strings(olderVersions)
 		olderProviderVersions[providerName] = olderVersions

diff --git a/provider/pkg/versioning/findOlderVersions_test.go b/provider/pkg/versioning/findOlderVersions_test.go
@@ -10,9 +10,9 @@ import (
 )
 
 func TestFindOlderVersions(t *testing.T) {
-	providerA := gofakeit.Noun()
-	resourceA := gofakeit.Noun()
-	resourceB := gofakeit.Noun()
+	providerA := "providerA"
+	resourceA := "resourceA"
+	resourceB := "resourceB"
 	olderVersion := fakeApiVersion(FakeApiVersion{})
 	versionA := fakeApiVersion(FakeApiVersion{GreaterThan: olderVersion})
 	versionB := fakeApiVersion(FakeApiVersion{GreaterThan: olderVersion})
@@ -36,7 +36,7 @@ func TestFindOlderVersions(t *testing.T) {
 			olderVersion,
 		},
 	}
-	assert.Equal(t, expected, olderVersions)
+	assert.Equal(t, expected, olderVersions, "olderVersion=%s, versionA=%s, versionB=%s", olderVersion, versionA, versionB)
 }
 
 type FakeApiVersion struct {
@@ -54,7 +54,7 @@ func fakeApiVersion(spec FakeApiVersion) openapi.ApiVersion {
 		min = min.AddDate(0, 0, 1)
 	}
 	if spec.LessThan != "" {
-		max, _ = time.Parse(ApiVersionLayout, spec.GreaterThan)
+		max, _ = time.Parse(ApiVersionLayout, spec.LessThan)
 		max = max.AddDate(0, 0, -1)
 	}
 	return gofakeit.DateRange(min, max).Format(ApiVersionLayout)