Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 is missing V1 lock resources as explicit versions #2634

Closed
danielrbradley opened this issue Aug 4, 2023 · 1 comment · Fixed by #2631 or #2642
Closed

V2 is missing V1 lock resources as explicit versions #2634

danielrbradley opened this issue Aug 4, 2023 · 1 comment · Fixed by #2631 or #2642
Assignees
@danielrbradley
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed resolution/wont-fix This issue won't be fixed
Milestone
0.93

Comments

@danielrbradley
Copy link
Member

The migration guide indicates these are expected to be here:

Import the previous version of the resource. These are available in the version-specific sub-folders of the SDK.
@danielrbradley danielrbradley added kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer labels Aug 4, 2023
@danielrbradley danielrbradley self-assigned this Aug 4, 2023
@danielrbradley danielrbradley mentioned this issue Aug 4, 2023
Merged
@mikhailshilkov mikhailshilkov added this to the 0.92 milestone Aug 4, 2023
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Aug 4, 2023
danielrbradley added a commit that referenced this issue Aug 4, 2023
@danielrbradley
Keep previous default resources (#2631)
9576129 
The intention when moving to v2 is that all the default resources in v1
would be available as explicit versions.

Somewhere along the way most of these go squeezed out. This PR ensures
that any explicit version from the previous versions's lock is included
as an explicit version's resource.

This adds approximately 1776 resources to each SDK (as well as
corresponding get methods).

Fixes #2634
@danielrbradley danielrbradley mentioned this issue Aug 4, 2023
Closed
@mikhailshilkov mikhailshilkov mentioned this issue Aug 9, 2023
Merged
@mikhailshilkov mikhailshilkov removed p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed labels Aug 11, 2023
@mikhailshilkov mikhailshilkov modified the milestones: 0.92, 0.93 Aug 11, 2023
@danielrbradley
Copy link
Member Author

We have decided against doing this work and are instead going to add a property to all resources to override the resource provider version so it's possible to use the same version as in V1.

@danielrbradley danielrbradley added the resolution/wont-fix This issue won't be fixed label Aug 29, 2023
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielrbradley danielrbradley

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed resolution/wont-fix This issue won't be fixed
Projects
None yet
Milestone
0.93
3 participants
@danielrbradley @mikhailshilkov @pulumi-bot