Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PULUMI_FORCE_NEW_FROM_SUBTYPES the default #3006

Closed
thomas11 opened this issue Jan 10, 2024 · 2 comments · Fixed by #3771
Closed

Make PULUMI_FORCE_NEW_FROM_SUBTYPES the default #3006

thomas11 opened this issue Jan 10, 2024 · 2 comments · Fixed by #3771
Assignees
@EronWright
Labels
3.0 kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@thomas11
Copy link
Contributor

#2970 extended the setting of forceNew, which causes resources to be replaced on certain property changes, to sub-properties. Since this is potentially disruptive, the new behavior is gated behind an environment variable PULUMI_FORCE_NEW_FROM_SUBTYPES.

In v3, this should be default as it's more correct behavior, and we can call it out in the change notes.
@thomas11 thomas11 added kind/enhancement Improvements or new features 3.0 labels Jan 10, 2024
@thomas11 thomas11 mentioned this issue Jan 10, 2024
Closed
@cleverguy25
Copy link

Added to epic https://github.com/pulumi/home/issues/3552

@EronWright EronWright self-assigned this Dec 6, 2024
@danielrbradley
Copy link
Member

To clarify, we should keep the environment variable, but allow it to be turned off instead of on in case users experience issues with it during their migration.

@EronWright EronWright mentioned this issue Dec 10, 2024
Merged
@EronWright EronWright moved this to In Progress in [Project] Azure Native V3 Dec 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in [Project] Azure Native V3 Dec 10, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EronWright EronWright

Labels
3.0 kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
[Project] Azure Native V3
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[v3] Make PULUMI_FORCE_NEW_FROM_SUBTYPES the default pulumi/pulumi-azure-native
5 participants
@thomas11 @danielrbradley @EronWright @cleverguy25 @pulumi-bot