-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OIDC file token authentication #3382
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3382 +/- ##
==========================================
+ Coverage 56.82% 56.87% +0.04%
==========================================
Files 66 66
Lines 8083 8092 +9
==========================================
+ Hits 4593 4602 +9
Misses 3055 3055
Partials 435 435 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core change looks okay, but I think we need to update the provider config in the schem, and update the docs too: https://www.pulumi.com/registry/packages/azure-native/installation-configuration/
Registry PR is already open, see PR description |
One typical way of authenticating via OIDC is that the identity provider supplies the OIDC token in a file. This provider already had support for this built in to the auth stack, but due to an oversight, validation wouldn't consider it and the provider would error before attempting to authenticate. This PR fixed this oversight and resolves #3373.
pulumi/registry#4790 updates the docs accordingly.