Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment: multi-assembly package #3746

Closed
wants to merge 1 commit into from
Closed

experiment: multi-assembly package #3746

wants to merge 1 commit into from

Conversation

EronWright
Copy link
Contributor

@EronWright EronWright commented Dec 3, 2024

A prototype, to be incorporated into code generation tooling.

This PR refactors the Pulumi.AzureNative assembly into a set of assemblies, bundled together into a Pulumi.AzureNative nuget package. The expected benefit is improved build time for the provider SDK, and possibly improved efficiency at runtime.

No impact is expected to consumer projects, they continue to use a <PackageReference> as normal. All assemblies in the package are included into the project's compile dependencies.

Before:

❯ tar -tf pulumi.azurenative.2.75.0.nupkg.tar
_rels/.rels
Pulumi.AzureNative.nuspec
lib/net6.0/Pulumi.AzureNative.pdb
lib/net6.0/Pulumi.AzureNative.dll
lib/net6.0/Pulumi.AzureNative.xml
content/version.txt
content/pulumi-plugin.json
logo.png
[Content_Types].xml
package/services/metadata/core-properties/91f7799ed2924b5f8dd79ab1a5266e88.psmdcp
.signature.p7s

After:

❯ tar -tf bin/Debug/Pulumi.AzureNative.2.0.0-alpha.0.nupkg
_rels/.rels
Pulumi.AzureNative.nuspec
lib/net6.0/Pulumi.AzureNative.Common.dll
lib/net6.0/Pulumi.AzureNative.Aad.dll
lib/net6.0/Pulumi.AzureNative.AadIam.dll
lib/net6.0/Pulumi.AzureNative.Addons.dll
...
lib/net6.0/Pulumi.AzureNative.WindowsESU.dll
lib/net6.0/Pulumi.AzureNative.WindowsIoT.dll
lib/net6.0/Pulumi.AzureNative.Workloads.dll
...
lib/net6.0/Pulumi.AzureNative.Common.xml
lib/net6.0/Pulumi.AzureNative.Aad.xml
lib/net6.0/Pulumi.AzureNative.AadIam.xml
lib/net6.0/Pulumi.AzureNative.Addons.xml
...
lib/net6.0/Pulumi.AzureNative.WindowsESU.xml
lib/net6.0/Pulumi.AzureNative.WindowsIoT.xml
lib/net6.0/Pulumi.AzureNative.Workloads.xml
content/version.txt
content/pulumi-plugin.json
logo.png
[Content_Types].xml
package/services/metadata/core-properties/ef56176ce1ce46809ab6450086a172fa.psmdcp

To build and install locally:

$ cd sdk/dotnet
$ dotnet pack Pulumi.AzureNative.csproj
$ nuget init bin/Debug bin/Debug/feed/
$ dotnet nuget locals global-packages --clear

See also: NuGet/Home#3891 (comment)

Copy link

github-actions bot commented Dec 3, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.80%. Comparing base (ee72d75) to head (00740f0).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3746   +/-   ##
=======================================
  Coverage   56.80%   56.80%           
=======================================
  Files          74       74           
  Lines       11838    11838           
=======================================
+ Hits         6724     6725    +1     
+ Misses       4619     4618    -1     
  Partials      495      495           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EronWright
Copy link
Contributor Author

TODO: include the PDBs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant