Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign Windows binaries #3774

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Sign Windows binaries #3774

wants to merge 2 commits into from
+25 −0

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Dec 11, 2024 •
edited
Loading

Sign windows binary via make and simplify CI. This makes it possible to produce signed binaries locally, if required.

  • Print when not signing with instructions.
  • Rename the unsigned binary if attempting to sign to avoid the target being up-to-date if a step fails so it's easier to retry.
  • Download the jar to the bin directory so it's not committed.
  • Set the required variables via ENV in CI for the duration of the dist target.

Alternative to #3764

@blampe @danielrbradley
Sign Windows binaries
dd6817f 
feedback

use bash shell

Sign windows binary via make

Simplify CI
@danielrbradley danielrbradley requested review from thomas11, blampe and a team December 11, 2024 08:57
@danielrbradley danielrbradley self-assigned this Dec 11, 2024
@danielrbradley danielrbradley mentioned this pull request Dec 11, 2024
Open
@github-actions GitHub Actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

thomas11
thomas11 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.66%. Comparing base (fcdfe88) to head (b9c3466).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3774   +/-   ##
=======================================
  Coverage   56.66%   56.66%           
=======================================
  Files          78       78           
  Lines       11975    11975           
=======================================
  Hits         6786     6786           
  Misses       4688     4688           
  Partials      501      501

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas11 thomas11 thomas11 approved these changes

@blampe blampe Awaiting requested review from blampe

Assignees

@danielrbradley danielrbradley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielrbradley @thomas11 @blampe