Remove generic version calculation #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves ~3.5s per makefile run: Before: make schema 3.90s user 1.09s system 94% cpu 5.296 total After: make schema 0.12s user 0.18s system 80% cpu 0.369 total
This is no longer required since adding respectSchemaVersion in the schema which creates these SDK-specific version numbers for us. - Remove version injection from dotnet, python and nodejs build steps. - Remove the unused SDK-specific version variables. - Create the dotnet version.txt as part of the generate step instead of the build. - Remove dependencies on pulumictl
danielrbradley
added
the
kind/engineering
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3775 +/- ##
==========================================
- Coverage 56.66% 56.65% -0.01%
==========================================
Files 78 78
Lines 11975 11975
==========================================
- Hits 6786 6785 -1
- Misses 4688 4689 +1
Partials 501 501 ☔ View full report in Codecov by Sentry. |
danielrbradley
temporarily deployed
to
env-ci
GitHub Actions
Inactive
danielrbradley
temporarily deployed
to
env-ci
GitHub Actions
Inactive
danielrbradley
temporarily deployed
to
env-ci
GitHub Actions
Inactive
danielrbradley
temporarily deployed
to
env-ci
GitHub Actions
Inactive
danielrbradley
temporarily deployed
to
env-ci
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unrequired complexity of parsing the version through pulumictl and the fiddly dependency because it's in a variable but uses a binary downloaded through a target.
Instead, just validate that the version isn't in the wrong format with a leading "v".
Speed boost
Speed up makefile initialisation by not scanning for updates of every individual spec file but instead just check the timestamp of the git internal file tracking what upstream HEAD is pointing at. This doesn't account for manual edits to the specs - this is not supported behaviour if using the default makefile build caching.
Remove SDK version injection
Use the same approach as bridged providers and just rely on
gen-sdkto insert the version into the SDK which it's already been doing since enablingrespectSchemaVersionin the schema for each language.