Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable RequireEmptyPreviewAfterRefresh for 2 tests #3374

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Jun 21, 2024

@danielrbradley danielrbradley requested a review from thomas11 June 21, 2024 08:10
@danielrbradley danielrbradley self-assigned this Jun 21, 2024
Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a green master build to prove it works since the PR workflow doesn't run all tests.

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.82%. Comparing base (d1a2366) to head (41452cc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3374   +/-   ##
=======================================
  Coverage   56.82%   56.82%           
=======================================
  Files          66       66           
  Lines        8083     8083           
=======================================
  Hits         4593     4593           
  Misses       3055     3055           
  Partials      435      435           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielrbradley danielrbradley enabled auto-merge (squash) June 21, 2024 09:02
@danielrbradley danielrbradley disabled auto-merge June 21, 2024 14:21
@danielrbradley danielrbradley merged commit 3530f17 into master Jun 21, 2024
25 checks passed
@danielrbradley danielrbradley deleted the skip-require-empty-preview-after-refresh branch June 21, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants