Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade tests #3763

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add upgrade tests #3763

wants to merge 3 commits into from

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Dec 9, 2024

Add tests to ensure that migrations from 2.x versions of resources to the latest version don't cause replacements.

Fixes #3421

Ideal resource coverage:

  • resources.ResourceGroup
  • keyvault.Vault
  • keyvault.Secret
  • keyvault.Key
  • network.VirtualNetwork
  • network.Subnet
  • network.NetworkInterface
  • network.PublicIPAddress
  • network.PrivateEndpoint
  • network.PrivateRecordSet
  • network.RecordSet
  • network.NetworkSecurityGroup
  • compute.VirtualMachine
  • storage.BlobContainer
  • storage.StorageAccount
  • storage.Blob
  • authorization.RoleAssignment
  • authorization.PolicyDefinitionAtManagementGroup
  • sql.FirewallRule
  • appconfiguration.KeyValue
  • sql.Database
  • sql.VirtualNetworkRule
  • sql.Server
  • web.WebApp
  • web.AppServicePlan
  • web.WebAppSlot
  • web.WebAppSlotConfigurationNames
  • insights.DiagnosticSetting
  • insights.MetricAlert
  • insights.Component
  • servicebus.Subscription
  • servicebus.Topic
  • servicebus.Queue
  • servicebus.Rule
  • managedidentity.UserAssignedIdentity
  • containerservice.AgentPool
  • app.ContainerApp
  • documentdb.SqlResourceSqlContainer
  • documentdb.DatabaseAccount
  • documentdb.SqlResourceDatabase
  • operationalinsights.Workspace
  • apimanagement.ApiOperationPolicy
  • apimanagement.Api

@danielrbradley danielrbradley self-assigned this Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (021d995) to head (f3cacfb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3763      +/-   ##
==========================================
+ Coverage   56.66%   56.83%   +0.16%     
==========================================
  Files          77       77              
  Lines       11954    11954              
==========================================
+ Hits         6774     6794      +20     
+ Misses       4682     4665      -17     
+ Partials      498      495       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add upgrade tests to test suite
2 participants