Use shorter DNS name for pod-to-pod networking #764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Eliminates the use of the hardcoded DNS suffix "svc.cluster.local", e.g. to support "VPC scope DNS".
Workspace RPC
For workspace RPC connectivity, the operator now uses the "namespace-scoped" short name of the workspace pod, e.g.
guestbook-workspace.default
rather thanguestbook-workspace.default.svc.cluster.local.
.This approach is an improvement but isn't ideal for cross-cluster communication. A possible future enhancement would be to fully resolve the address to be persisted in the status block (e.g. to
guestbook-workspace.default.svc.cluster1.
).See DNS for Services and Pods for more information, which says:
Program Artifact
The program artifact is fetched by workspace pods from the controller itself, based on the configured advertised address. This PR shortens the advertised address used by the default installation manifest, and updates the Helm chart to support a configurable override.
Related issues (optional)
Closes #759