-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove v1 code #681
Remove v1 code #681
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #681 +/- ##
==========================================
- Coverage 33.24% 33.11% -0.14%
==========================================
Files 25 27 +2
Lines 3949 4161 +212
==========================================
+ Hits 1313 1378 +65
- Misses 2474 2610 +136
- Partials 162 173 +11 ☔ View full report in Codecov by Sentry. |
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1 | |||
kind: CustomResourceDefinition | |||
metadata: | |||
annotations: | |||
controller-gen.kubebuilder.io/version: v0.15.0 | |||
controller-gen.kubebuilder.io/version: v0.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
𝖶̶𝖾̶ ̶𝗌̶𝗁̶𝗈̶𝗎̶𝗅̶𝖽̶ ̶𝖿̶𝗂̶𝗇̶𝖽̶ ̶𝖺̶ ̶𝗐̶𝖺̶𝗒̶ ̶𝗍̶𝗈̶ ̶𝗌̶𝗒̶𝗇̶𝖼̶ ̶𝗎̶𝗉̶ ̶𝗈̶𝗎̶𝗋̶ ̶𝖽̶𝖾̶𝗏̶ ̶𝖽̶𝖾̶𝗉̶𝖾̶𝗇̶𝖽̶𝖾̶𝗇̶𝖼̶𝗂̶𝖾̶𝗌̶ ̶𝗌̶𝗈̶ ̶𝗐̶𝖾̶ ̶𝖽̶𝗈̶𝗇̶'̶𝗍̶ ̶𝗈̶𝗌̶𝖼̶𝗂̶𝗅̶𝗅̶𝖺̶𝗍̶𝖾̶ ̶𝖻̶𝖾̶𝗍̶𝗐̶𝖾̶𝖾̶𝗇̶ ̶𝗏̶𝖾̶𝗋̶𝗌̶𝗂̶𝗈̶𝗇̶𝗌̶.̶ Actually, this is the diff between v1 and v2 manifests. The tooling used for both are different, so some differences are expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still, I agree that the makefile isn't doing enough here and will invesigate.
@@ -9,7 +9,7 @@ icon: https://www.pulumi.com/logos/brand/avatar-on-white.svg | |||
|
|||
type: application | |||
|
|||
version: 0.8.0 | |||
version: 0.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we wait on bumping this until we want to trigger a helm release/publish?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the chart linter insisted that it be bumped because the crd directory has changed.
|
||
```bash | ||
pulumi stack select dev | ||
kubectl exec --stdin --tty my-stack-0q4s6z9z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Proposed changes
Remove any now-obsolete v1 code and fix-up the Makefile. Most of the top-level build targets work as expected, often by delegating to the sub-Makefiles.
TODO:
Later:
New Help Output
Related issues (optional)