Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v1 code #681

Merged
merged 10 commits into from
Sep 25, 2024
Merged

Remove v1 code #681

merged 10 commits into from
Sep 25, 2024

Conversation

EronWright
Copy link
Contributor

@EronWright EronWright commented Sep 24, 2024

Proposed changes

Remove any now-obsolete v1 code and fix-up the Makefile. Most of the top-level build targets work as expected, often by delegating to the sub-Makefiles.

TODO:

  • CI scripts

Later:

  • Deployment-related changes (to take place in a separate PR)
  • Top-level tests

New Help Output

❯ make help

Usage:
  make <target>

General
  help             Display this help.

Development
  codegen          Generate CRDs and documentation
  generate-crdocs  Generate API Reference documentation into 'docs/crds/'.

Build
  build            Build the agent and operator binaries. 
  build-agent      Build the agent binary.
  build-operator   Build the operator manager binary.
  build-image      Build the operator image.
  push-image       Push the operator image.

Deployment
  install-crds     Install CRDs into the K8s cluster specified in ~/.kube/config.
  deploy           Deploy controller manager to the K8s cluster specified in ~/.kube/config.

Release
  prep             Prepare the next release.

Build Dependencies
  crdoc            Download crdoc locally if necessary. No version check.

Related issues (optional)

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.11%. Comparing base (ab6c570) to head (c848bc6).
Report is 4 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #681      +/-   ##
==========================================
- Coverage   33.24%   33.11%   -0.14%     
==========================================
  Files          25       27       +2     
  Lines        3949     4161     +212     
==========================================
+ Hits         1313     1378      +65     
- Misses       2474     2610     +136     
- Partials      162      173      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EronWright EronWright added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Sep 24, 2024
@EronWright EronWright marked this pull request as ready for review September 24, 2024 23:55
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.15.0
controller-gen.kubebuilder.io/version: v0.14.0
Copy link
Member

@rquitales rquitales Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

𝖶̶𝖾̶ ̶𝗌̶𝗁̶𝗈̶𝗎̶𝗅̶𝖽̶ ̶𝖿̶𝗂̶𝗇̶𝖽̶ ̶𝖺̶ ̶𝗐̶𝖺̶𝗒̶ ̶𝗍̶𝗈̶ ̶𝗌̶𝗒̶𝗇̶𝖼̶ ̶𝗎̶𝗉̶ ̶𝗈̶𝗎̶𝗋̶ ̶𝖽̶𝖾̶𝗏̶ ̶𝖽̶𝖾̶𝗉̶𝖾̶𝗇̶𝖽̶𝖾̶𝗇̶𝖼̶𝗂̶𝖾̶𝗌̶ ̶𝗌̶𝗈̶ ̶𝗐̶𝖾̶ ̶𝖽̶𝗈̶𝗇̶'̶𝗍̶ ̶𝗈̶𝗌̶𝖼̶𝗂̶𝗅̶𝗅̶𝖺̶𝗍̶𝖾̶ ̶𝖻̶𝖾̶𝗍̶𝗐̶𝖾̶𝖾̶𝗇̶ ̶𝗏̶𝖾̶𝗋̶𝗌̶𝗂̶𝗈̶𝗇̶𝗌̶.̶ Actually, this is the diff between v1 and v2 manifests. The tooling used for both are different, so some differences are expected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, I agree that the makefile isn't doing enough here and will invesigate.

@@ -9,7 +9,7 @@ icon: https://www.pulumi.com/logos/brand/avatar-on-white.svg

type: application

version: 0.8.0
version: 0.9.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait on bumping this until we want to trigger a helm release/publish?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the chart linter insisted that it be bumped because the crd directory has changed.


```bash
pulumi stack select dev
kubectl exec --stdin --tty my-stack-0q4s6z9z
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@EronWright EronWright merged commit 8ac74b0 into v2 Sep 25, 2024
9 checks passed
@EronWright EronWright deleted the issue-680 branch September 25, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants